Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait up to 1s to let aria2c to start #1169

Merged
merged 1 commit into from
Jan 12, 2025
Merged

Wait up to 1s to let aria2c to start #1169

merged 1 commit into from
Jan 12, 2025

Conversation

kelson42
Copy link
Collaborator

@kelson42 kelson42 added this to the 14.1.0 milestone Dec 24, 2024
Copy link

codecov bot commented Dec 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 41.47%. Comparing base (2e3eae5) to head (9884983).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/aria2.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1169   +/-   ##
=======================================
  Coverage   41.47%   41.47%           
=======================================
  Files          59       59           
  Lines        4272     4272           
  Branches     2336     2336           
=======================================
  Hits         1772     1772           
  Misses        999      999           
  Partials     1501     1501           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kelson42
Copy link
Collaborator Author

kelson42 commented Jan 9, 2025

@veloman-yunkan Any news on this review?

Copy link
Collaborator

@veloman-yunkan veloman-yunkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, it took me 3 weeks to review a half-a-second PR :)

@kelson42 kelson42 merged commit bb65d77 into main Jan 12, 2025
16 checks passed
@kelson42 kelson42 deleted the wait-1s-to-aria2c branch January 12, 2025 11:17
@kelson42 kelson42 changed the title Wait up to 1s to le aria2c to start Wait up to 1s to let aria2c to start Jan 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aria2 rpc connection failure on start
2 participants