fix: Make settings tab scrollable for better accessibility on small screens #1269
Conversation
There was a problem hiding this comment.
This solves the reported issue (which was a functional limitation) but breaks some aesthetics when there is enough space:
So I think that @kelson42 should be the main reviewer for this PR.
|
@veloman-yunkan @kelson42 I have fixed the alignment, kindly review it |
kelson42
force-pushed
the
fix/scrollable-settings
branch
from
f76d090 to
edc5283
Compare
|
@heropj I don't understand indeed, why a border has been added around the settings, this was not requested and breaks the overall estetic IMHO too. Is is possible to remove it. Otherwise the PR seems to work fine to me. |
heropj
force-pushed
the
fix/scrollable-settings
branch
from
edc5283 to
6d6de66
Compare
|
@veloman-yunkan if good for you I will merge |
kelson42
force-pushed
the
fix/scrollable-settings
branch
from
6d6de66 to
5e1ad11
Compare
|
Hello kiwix community, i am Noorie garg, a college student and i have been exploring kiwix for a while. I installed kiwix on my pc and saw all its features. But there is no scrollable feature in the settings tab (i am writing this after coming across this closed pull request). I would be glad if anyone could make some time to resolve my query. Thanks! |
edit: sorry my bad....i just searched that the version available on kiwix website is 2.0 and this feature is suppose to be in 2.4...i guess this resolves my doubt |
|
@nooriegarg Thank you for Our message, you can teat the nightly here http://download.kiwix.org/nightly/2024-12-13/kiwix-desktop_windows_x64_2024-12-13.zip |
fix #1261
Changes: