fix the max functions

kiwicopple · Jan 20, 2023 · ca722bb · ca722bb · vercel · Jan 20, 2023
1 parent 4469724
commit ca722bb
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 8 deletions.
diff --git a/components/Issues.tsx b/components/Issues.tsx
@@ -100,7 +100,7 @@ FORMAT JSON`,
   if (!data) return <div>Loading...</div>
 
   const chartData = data.data
-  const max = parseInt(findMax(chartData, 'tally').toString())
+  const max = findMax(chartData, "tally")
 
   return (
     <Card>

diff --git a/components/PullRequests.tsx b/components/PullRequests.tsx
@@ -100,7 +100,7 @@ FORMAT JSON`,
   if (!data) return <div>Loading...</div>
 
   const chartData = data.data
-  const max = parseInt(findMax(chartData, 'tally').toString())
+  const max = findMax(chartData, "tally")
 
   return (
     <Card>

diff --git a/components/Stars.tsx b/components/Stars.tsx
@@ -40,10 +40,12 @@ FORMAT JSON`,
   // console.log("data", data)
   // console.log("error", error)
 
-  if (!data) return <div>Loading...</div>
+  if (!data || !data.data) return <div>Loading...</div>
 
   const starHistory = data.data
-  const max = parseInt(starHistory[starHistory.length - 1]["stars"])
+  const max = starHistory.length
+    ? parseInt(starHistory[starHistory.length - 1]["stars"])
+    : 0
   return (
     <Card>
       <div className="md:flex justify-between">

diff --git a/lib/helpers.ts b/lib/helpers.ts
@@ -16,11 +16,13 @@ export const useUrlFilters = (): UrlFilters => {
 }
 
 // Find the max value from an array of objects (or just an array of numbers)
-export function findMax(objects: any[], key?: string) {
+export function findMax(objects: any[], key?: string): number {
   let max = 0
   for (let i = 0; i < objects.length; i++) {
-    const val = key? objects[i][key]:  objects[i]
-    if (val > max) max = val
+    const val: number = key ? objects[i][key] : objects[i]
+    const valInt = parseInt(val.toString())
+    if (valInt > max) max = valInt
   }
+  console.log("max", max)
   return max
-}
+}