Skip to content

scipy: update to v1.15.2 #3136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from
Draft

Conversation

T-Dynamos
Copy link
Contributor

@T-Dynamos T-Dynamos commented Mar 27, 2025

Closes #3116

Cons:

  1. Can't build on macos
  2. Needs android 7 and 7+
  3. Only 64 bit arches supported

Extra Notes:

Removes need to use LEGACY_NDK as it uses fortran from https://github.com/termux/ndk-toolchain-clang-with-flang.

@T-Dynamos
Copy link
Contributor Author

SDL does not builds with ndk r27c because of libsdl-org/SDL#9792.
So we need to wait for #3125.

CC: @misl6

@misl6
Copy link
Member

misl6 commented Mar 27, 2025

Will continue working on the SDL3 recipes this weekend, however we are going to support both SDL2 and SDL3 for a long time, as only Kivy 3.0.0 will support SDL3, and will not be ready quite soon.

Maybe we can use NDK 27 only for some specific recipes? (or a previous one for SDL2)

@T-Dynamos
Copy link
Contributor Author

Just saw fixed was also pushed for SDL2, so bumped version to include that fix. :)

@T-Dynamos T-Dynamos force-pushed the scipy_update branch 2 times, most recently from 5e09b20 to 48a215a Compare March 28, 2025 04:15
@T-Dynamos T-Dynamos force-pushed the scipy_update branch 2 times, most recently from df40a87 to b972e5a Compare April 12, 2025 13:11
Copy link
Member

@AndreMiras AndreMiras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Impressive work so far!
Thanks for picking this up too @T-Dynamos 🙏
Maybe it's a good time to rebase it since SDL3 (#3125) was merged

@T-Dynamos
Copy link
Contributor Author

Should I document this things or add warnings in code:

 Can't build on macos
 Only 64 bit arches supported

@T-Dynamos T-Dynamos force-pushed the scipy_update branch 2 times, most recently from ec0465d to a8d8c9b Compare April 20, 2025 16:27
@AndreMiras
Copy link
Member

Should I document this things or add warnings in code:

 Can't build on macos
 Only 64 bit arches supported

Yeah maybe failing early with an explicit message would do it, what do you think?
Which makes me think, maybe in the future we want a consistent behavior for this case and have something like "unsupported_arch" attribute in a recipe (empty by default) that would make the build fail fast with an explicit message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SciPy recipe fails with current development branch of P4A
4 participants