Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/strafing timeline #27

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Conversation

peterlipt
Copy link
Member

No description provided.

@peterlipt peterlipt requested a review from balog-b December 29, 2024 13:20
@peterlipt peterlipt self-assigned this Dec 29, 2024
@peterlipt peterlipt linked an issue Dec 29, 2024 that may be closed by this pull request
Copy link

vercel bot commented Dec 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
epitesz-klub ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 20, 2025 4:33pm

src/app/(app)/Components/Timeline.tsx Outdated Show resolved Hide resolved
Comment on lines 27 to 38
<div className="min-h-screen p-8 w-full relative" style={{ height: `${totalHeight}px` }}>
{/* Timeline path */}
<div className="absolute left-0 top-0 w-full" style={{ height: `${totalHeight}px` }}>
<svg
className="w-full"
style={{
height: `${totalHeight}px`,
strokeWidth: '4px',
stroke: 'white',
fill: 'none'
}}
>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use tailwind:

https://tailwindcss.com/docs/height#arbitrary-values
https://tailwindcss.com/docs/stroke
https://tailwindcss.com/docs/stroke-width#arbitrary-values
https://tailwindcss.com/docs/fill

Note that when a value is not present in any tailwind className, you can use [] to add an arbitrary value. For example here it would be {h-[${totalHeight}px]}

This will work if totalHeight is constant. If totalHeight would be a variable, you would need to use the style method, so that it updates after the variable changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Component: Strafing Timeline
2 participants