Allow overriding transition parameters (fixes transitive-bullshit#15)

kingpalethe · Jun 20, 2018 · 972570a · 972570a
1 parent c5887d2
commit 972570a
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 5 deletions.
diff --git a/lib/render-frames.js b/lib/render-frames.js
@@ -76,7 +76,8 @@ module.exports.renderFrame = async (opts) => {
     await ctx.render({
       imagePathFrom: cFramePath,
       imagePathTo: nFramePath,
-      progress: cProgress
+      progress: cProgress,
+      params: current.transition.params
     })
 
     await ctx.capture(filePath)

diff --git a/lib/transition.js b/lib/transition.js
@@ -32,7 +32,8 @@ module.exports = (opts) => {
     draw: async ({
       imagePathFrom,
       imagePathTo,
-      progress
+      progress,
+      params
     }) => {
       gl.clear(gl.COLOR_BUFFER_BIT)
 
@@ -54,7 +55,7 @@ module.exports = (opts) => {
       textureTo.magFilter = gl.LINEAR
 
       buffer.bind()
-      transition.draw(progress, textureFrom, textureTo)
+      transition.draw(progress, textureFrom, textureTo, gl.drawingBufferWidth, gl.drawingBufferHeight, params)
 
       textureFrom.dispose()
       textureTo.dispose()

diff --git a/readme.md b/readme.md
@@ -70,7 +70,8 @@ await concat({
   ],
   transition: {
     name: 'directionalWipe',
-    duration: 500
+    duration: 500,
+    params: {direction: [1, -1]}
   }
 })
 ```
@@ -148,7 +149,8 @@ Note that you must specify either `transition` or `transitions`, depending on ho
 // example
 const transition = {
   duration: 1000, // ms
-  name: 'directionalwipe' // gl-transition name to use (will match with lower-casing)
+  name: 'directionalwipe', // gl-transition name to use (will match with lower-casing)
+  params: {direction: [1, -1]} // optionally override default parameters
 }
 ```