Skip to content

Argument fix for single_connection method #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

CaptainFaisal
Copy link

@CaptainFaisal CaptainFaisal commented Sep 10, 2024

Check the 4th parameter of single_connection method's definition, it's pbc_mode, so we need to pass args.pbc as 4th argument here.

Summary by Sourcery

Fix the argument order in the call to the single_connection method by passing args.pbc as the fourth argument instead of args.pixie_dust.

Bug Fixes:

  • Fix the argument passed to the single_connection method by replacing the incorrect third argument with the correct fourth argument, args.pbc.

Check the 4th parameter of single_connection method's definition, it's pbc_mode, so we need to pass args.pbc as 4th argument here.
Copy link

sourcery-ai bot commented Sep 10, 2024

Reviewer's Guide by Sourcery

This pull request fixes an argument mismatch in the single_connection method call within the oneshot.py file. The change ensures that the pbc_mode parameter is correctly passed as the fourth argument.

File-Level Changes

Change Details Files
Corrected argument order in single_connection method call
  • Added args.pbc as the fourth argument to the single_connection method call
  • Aligned the method call with its definition, which expects pbc_mode as the fourth parameter
oneshot.py

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @CaptainFaisal - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant