Skip to content

fix(keyboard): debounce Enter key and block during submission #1311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kike-alt merged 1 commit into from
Aug 26, 2026
Merged

fix(keyboard): debounce Enter key and block during submission #1311

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions frontend/src/hooks/useKeyboardNavigation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,11 @@ export interface KeyboardNavigationOptions {
onEscape?: () => void;
onQuestionMark?: () => void;
enabled?: boolean;
isSubmitting?: boolean;
}

const ENTER_DEBOUNCE_MS = 300;

export function useKeyboardNavigation(options: KeyboardNavigationOptions) {
const {
onArrowUp,
Expand All @@ -23,10 +26,12 @@ export function useKeyboardNavigation(options: KeyboardNavigationOptions) {
onEscape,
onQuestionMark,
enabled = true,
isSubmitting = false,
} = options;

const handlersRef = useRef(options);
handlersRef.current = options;
const lastEnterTime = useRef(0);
const handlersRef = useRef({ ...options, isSubmitting });
handlersRef.current = { ...options, isSubmitting };

const handleKeyDown = useCallback(
(event: KeyboardEvent) => {
Expand Down Expand Up @@ -60,7 +65,13 @@ export function useKeyboardNavigation(options: KeyboardNavigationOptions) {
break;
case "Enter":
event.preventDefault();
handlersRef.current.onEnter?.();
if (!handlersRef.current.isSubmitting) {
const now = Date.now();
if (now - lastEnterTime.current >= ENTER_DEBOUNCE_MS) {
lastEnterTime.current = now;
handlersRef.current.onEnter?.();
}
}
break;
case "Backspace":
event.preventDefault();
Expand Down
Loading