Replace Logger with CommonLogger #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjamrog
commented
Dec 12, 2024
UPGRADING.md
Outdated
| @@ -1,5 +1,18 @@ | |||
| # Upgrading Guide | |||
|
|
|||
| ## Upgrading from `17.0.0` to `18.0.0` | |||
There was a problem hiding this comment.
core is updated to 18.0.0 but sns and amqp are updated to different versions, should we indicate that here?
There was a problem hiding this comment.
I think breaking change is the same for all libraries, right?
Maybe we can do something like:
- mqt/core from 17.0.0 to 18.0.0
- amqp from x to y
- ...
There was a problem hiding this comment.
Yeah, that will be probably more clear, already updated
kjamrog
changed the title
CarlosGamero
approved these changes
Dec 18, 2024
kibertoad
reviewed
Jan 2, 2025
UPGRADING.md
Outdated
| ## Upgrading </br> `core` `17.0.0` -> `18.0.0` </br> `sqs` `17.0.0` -> `18.0.0` </br> `sns` `18.0.0` -> `19.0.0` </br> `amqp` `16.0.0` -> `17.0.0` | ||
|
|
||
| ### Description of Breaking Changes | ||
| - `logger` injectable dependency interface was replaced by `CommonLogger` from `@lokalise/node-core` package, It is compatible with on `pino` logger (https://github.com/pinojs/pino) |
kibertoad
approved these changes
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of internal
Loggertype,CommonLoggerinterface from@lokalize/node-coreis used