Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #474- Improve doc on how to pass parameter to MavenOption when using MavenCLIOptions #475

Merged
merged 2 commits into from
Jul 22, 2024
Merged

Fixed #474- Improve doc on how to pass parameter to MavenOption when using MavenCLIOptions #475

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7bb7281
Describe how to pass parameter to MavenOption annotation
Bukama Jun 22, 2024
2d9c2f6
Add entry to release notes
Bukama Jul 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions itf-documentation/src/main/asciidoc/release-notes/_release-notes-0.14.0.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@
:issue-468: https://github.com/khmarbaise/maven-it-extension/issues/468[Fixed #468]
:pr-460: https://github.com/khmarbaise/maven-it-extension/pull/460[Pull request #460]
:pr-462: https://github.com/khmarbaise/maven-it-extension/pull/462[Pull request #462]
:issue-474: https://github.com/khmarbaise/maven-it-extension/issues/474[Fixed #474]

:release_0_14_0: https://github.com/khmarbaise/maven-it-extension/milestone/14

Expand Down
14 changes: 13 additions & 1 deletion itf-documentation/src/main/asciidoc/usersguide/usersguide.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -783,7 +783,7 @@ void first( MavenExecutionResult result )
----

[[structuring.default.goals.options]]
=== Default Goals,Options
=== Default Goals, Options

[[structuring.goals]]
==== Goals
Expand Down Expand Up @@ -970,6 +970,18 @@ class BasicIT {
}
}
----
If you want to pass a parameter to a `@MavenOption` you have to name the parameters explicit like this:
[source,java]
----
@MavenJupiterExtension
class BasicIT {

@MavenTest
@MavenOption(value = MavenCLIOptions.FILE, parameter = 'path/to/pom.xml')
void first(MavenExecutionResult result) {
}
}
----
Now let us summarize the information for options. As long as no explicit `@MavenOption` is defined the
default will be used which are the following:

Expand Down
Loading