review: khushi/watch-prod-final (informer) #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* changes related to aad msi auth feature * use existing envvars * fix imds token expiry interval * refactor the windows agent ingestion token code * code cleanup * fix build errors * code clean up * code clean up * code clean up * code clean up * more refactoring * fix bug * fix bug * add debug logs * add nil checks * revert changes * revert yaml change since this added in aks side * fix pr feedback * fix pr feedback * refine retry code * update mdsd env as per official build * cleanup * update env vars per mdsd * update with mdsd official build * skip cert gen & renewal incase of aad msi auth * add nil check * cherry windows agent nodeip issue * fix merge issue Co-authored-by: rashmichandrashekar <[email protected]>
* remove chart version dependency * remove unused code * fix resource type * fix * handle weird cli chars * update release process
* use artifact and pipeline creds for image push * minor update * add vuln fix here so that pr can be merged
* fix telegraf telemetry and improve fluentd liveness * address identified vuln with libsystemd0 * fix exported image file extension
* tail rs mdsd err logs * configure mdsd log rotation * log rotation for mdsd log files
Co-authored-by: Vladimir Babichev <[email protected]>
* add telemetry to track fbit settings * add telemetry to track fbit settings
* conf test updates * clean up * wip * update with mcr cidev image * handle log path * cleanup * clean up * wip * working * update for mcr image * minor * image update * handle latency of connected cluster resource creation * update conftest image
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the working version that utilizes the informer approach