Skip to content

Comments

feature(graduate): 학생 상세보기 api 연동#206

Merged
yummjin merged 6 commits intodevelopfrom
feature/204
Dec 27, 2025
Merged

feature(graduate): 학생 상세보기 api 연동#206
yummjin merged 6 commits intodevelopfrom
feature/204

Conversation

@seoJing
Copy link
Contributor

@seoJing seoJing commented Dec 26, 2025

Summary

#204

Tasks

  • 학생 상세보기 api 연동 및 feature 분리
  • allgraduation 테이블 type 수정 ( 실제 api 구조에 맞춤 )
  • qa

Screenshot

image

@seoJing seoJing requested a review from a team as a code owner December 26, 2025 10:05
@vercel
Copy link

vercel bot commented Dec 26, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
aics-admin Ready Ready Preview, Comment Dec 27, 2025 3:41pm
aics-client Ready Ready Preview, Comment Dec 27, 2025 3:41pm

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 26, 2025

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feature/204

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@seoJing seoJing self-assigned this Dec 26, 2025
@seoJing seoJing added the enhancement New feature or request label Dec 26, 2025
Copy link
Member

@yummjin yummjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰, Approve 늦게 해드려 죄송해요 🥺
추가로, 조건 분기문의 경우 if-else 보단 switch 문의 각 case 를 통해 어떤 조건에 어떤 로직이 매칭되는지 구분하는 것이 어떤 조건이 존재하는지 알기도 쉽고 차후에 조건이 추가된다면 수정점을 잡는 데에도 더 좋아요. 제가 짚어드린 부분 외에도 status.type 에 따라 다른 로직을 적용해야 하는 부분이 있다면 이점 생각하며 구현해 보시면 좋지 않을까 싶습니다!
작업 수고하셨어요 ~ 👍

@yummjin yummjin merged commit d60c2e7 into develop Dec 27, 2025
6 checks passed
@yummjin yummjin deleted the feature/204 branch December 27, 2025 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants