feat: add new method for select device by touching on it #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new method for selecting a device when there are multiple. The helper function triggers all devices in the list to blink until one of them is touched by the user or the timeout has exceeded. The touched device is returned (but in a new
Deviceinstance). It uses these libfido methods and the polling is similar to the C example here, but using go routines.The windows header files in this repository does not yet contain the needed functions and I am unsure how to properly update them. It seems like it might require changes in the scoop package, too.
Please let me know if this could be merged, or what needs to happen to add this kind of functionality. Thanks!