Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add signing keys to website #555

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add signing keys to website #555

wants to merge 1 commit into from

Conversation

stianst
Copy link
Contributor

@stianst stianst commented Jan 23, 2025 •
edited
Loading

image

sschu
sschu approved these changes Jan 23, 2025
View reviewed changes
Copy link

@sschu sschu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

ahus1
ahus1 requested changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@ahus1 ahus1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see you are adding a page, still I can't see where you link it. Do you plan to link it from the Downloads page?

pages/keys.ftl
</tr>
<tr>
<td>d77f6183986627e454951a5ca63faed146e27e2a</td>
<td>Keycloak Terraform Team<br/>[email protected]&gt;</td>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<td>Keycloak Terraform Team<br/>[email protected]&gt;</td>
<td>Keycloak Terraform Team<br/>[email protected]</td>

ahus1
ahus1 reviewed Jan 24, 2025
View reviewed changes
pages/keys.ftl
<@tmpl.page current="keys" title="Keycloak Signing Keys">

<div class="container mt-5">
<h1>Keycloak Signing Keys</h2>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<h1>Keycloak Signing Keys</h2>
<h1>Keycloak Signing Keys</h1>

@stianst
Copy link
Contributor Author

stianst commented Jan 24, 2025

I see you are adding a page, still I can't see where you link it. Do you plan to link it from the Downloads page?

Maybe, wasn't quite sure where to link it. Downloads would for sure make sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahus1 ahus1 ahus1 requested changes

@sschu sschu sschu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stianst @sschu @ahus1