Skip to content

Fix dependency bug in fir_filter #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix dependency bug in fir_filter #16

wants to merge 3 commits into from

Conversation

oswald3141
Copy link
Contributor

Add an implementation of tapped_delay_line which is not present in
pipelining package.
Closes #4.
Thanks to @cweickhmann for help and the example of an implementation.

@oswald3141
Remove a chunk of commented code
f469070 
The code seems to be a previous version of fir_filter entity.
@oswald3141
Fix use of sizing package
866fef8 
Use 2008 version. Mention it in the dependencies list.
@oswald3141
Fix dependency bug in fir_filter
8988f87 
Add an implementation of tapped_delay_line which is not present in
pipelining package.
@cweickhmann
Copy link

cweickhmann commented Jul 19, 2023 •
edited
Loading

Hi! It seems the reference to tapped_delay_line is now in the docs (doc/rst/modules/pipelining.rst) and it's referenced in rtl/extras_2008/filtering.vhdl, but it's no in rtl/extras_2008/pipelining_2008.vhdl.
Did this go missing on your local repository, maybe?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing 2008 pipelining variant
2 participants
@oswald3141 @cweickhmann