fix Starlette TestClient #923
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I'm trying to get Starlette
TestClient
running withvcrpy
.The problem is that
assert not hasattr(resp, "_decoder")
fails in_to_serialized_response
func, which breaksvcr
for Starlette TestClient, see #628.I see two possible solutions here:
First approach (implemented)
From
docs/advanced.rst
:Which means it is safe to completely ignore these requests when recording responses.
If we don't record responses, we don't hit this
assert
.Second approach
Fix buggy
_run_async_function
(sorry, it was me who messed it up):Because right now it is bugged - we run a task in asyncio but never wait for it to finish.
@jairhenrique what do you think? Should I apply both fixes?
Fixes #628.