Fix test failure in guides writing_your_own_callbacks.py #21671
Conversation
Fix `AttributeError: `np.Inf` was removed in the NumPy 2.0 release. Use `np.inf` instead.` exception
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @TRNWWZ, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request addresses a critical compatibility issue within the Keras guides, specifically fixing an AttributeError in writing_your_own_callbacks.py. The error arose from an API change in NumPy 2.0, which deprecated np.Inf in favor of np.inf. By updating this single constant, the PR ensures that the guide remains functional and compatible with modern NumPy installations, allowing users to run the example code without encountering unexpected failures.
Highlights
- Test Fix: Resolved a test failure in
guides/writing_your_own_callbacks.pythat occurred when running tests under theguidesdirectory. - NumPy Compatibility: Updated the usage of
np.Inftonp.infto align with changes introduced in NumPy 2.0, which removed the uppercase version. - Guide Functionality: Ensured that the
writing_your_own_callbacks.pyguide can run successfully with the latest NumPy versions (e.g., 2.3.3) without encountering anAttributeError.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request addresses a compatibility issue with NumPy 2.0 in the writing_your_own_callbacks.py guide. The change correctly replaces the deprecated np.Inf with np.inf, ensuring the example code remains functional with modern versions of the NumPy library. The fix is straightforward, effective, and aligns with NumPy conventions. I have reviewed the change and found no issues.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #21671 +/- ##
==========================================
+ Coverage 76.77% 82.56% +5.79%
==========================================
Files 571 571
Lines 57718 57718
Branches 9017 9017
==========================================
+ Hits 44311 47654 +3343
+ Misses 11063 7765 -3298
+ Partials 2344 2299 -45
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
google-ml-butler
bot
added
kokoro:force-run
ready to pull
When running tests under
guides, I noticedwriting_your_own_callbacks.pyfailing with error:As
numpyhas been released to 2.3.3, raising this small fix to makewriting_your_own_callbacks.pyable to run along with latestnumpyversion.The change has been verified against
keras=3.11.3version.