This repository was archived by the owner on Apr 25, 2023. It is now read-only.
Update ddqn.py #30
Open
Update ddqn.py #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It did not converge so i did some changes it also improves performance it solves cartpole after 30 episodes Changes to hyperparameters actual train in batches in the replay method(far better perfomance on big batches) stop episode when done
keon
reviewed
Jan 27, 2020
| def replay(self, batch_size): | ||
| minibatch = random.sample(self.memory, batch_size) | ||
| stateBatch = np.zeros((batch_size,self.state_size)) | ||
| targetBatch = np.zeros((batch_size,self.action_size)) |
There was a problem hiding this comment.
could you use snake case to match with the rest of the code?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It did not converge for me and it was very slow. So i did some changes it also improves performance
it solves cartpole after 30 episodes
Changes to hyperparameters
actual train in batches in the replay method(far better perfomance on big batches)
stop episode when done