feat(people): add provider presets and gate Codex enrollment - #918
salmonumbrella wants to merge 4 commits into
Conversation
roborev: Combined Review (
|
84c7900 to
e87cb54
Compare
roborev: Combined Review (
|
e87cb54 to
414cbb0
Compare
roborev: Combined Review (
|
414cbb0 to
f32e361
Compare
roborev: Combined Review (
|
f32e361 to
ec9ba5b
Compare
roborev: Combined Review (
|
ec9ba5b to
354d2f9
Compare
This comment has been minimized.
This comment has been minimized.
Preset setup can stop after creating a profile but before saving its key. Keep that profile recoverable and removable. Credential changes must revoke both saved and running authority while a daemon restart is pending, and browser requests must not choose host environment variables as credentials. Codex has no approved inference build. Refuse enrollment before it changes credentials or consent, and preserve same-account credential refreshes on all process exits. Packaging and artifact certification remain prerequisites for enabling Codex. Protocol fixtures exercise persistence at the external process boundary without requiring a live provider account. Use the existing web controller and browser test patterns so settings do not maintain competing copies of provider state. Preserve daemon errors and document the explicit provider choices required by setup. Generated with Codex Co-authored-by: Codex <noreply@openai.com>
The Linux release job omitted the static bridge and its checksum, so its binaries could not launch Codex after the release gate opened. Build the bridge for each job's architecture beside msgvault and link its digest into that daemon. The Codex certification gate remains closed. Addresses finding 1 in the review of 354d2f9: kenn-io#918 (comment) Finding 2 from that review is stale at db854b6a: login rejects an existing profile name before revoking authority. API regression coverage exercises the conflict without invalidating the existing profile's consent. Generated with Codex Co-authored-by: Codex <noreply@openai.com>
The current lint rules reject wall-clock sleeps in tests. Wait for the login session's completion signal and use a simulated clock for the slow auth-commit case. These checks still cover completed-session ownership and preserving refreshed credentials beyond the child-exit timeout. Generated with Codex Co-authored-by: Codex <noreply@openai.com>
354d2f9 to
c42ecf1
Compare
roborev: Combined Review (
|
People inference gains OpenAI, OpenRouter, and Venice presets with fixed endpoints, write-only key entry, and explicit model and privacy choices. Setup no longer treats an OpenAI key as a request to enable people inference. Checks, disclosure consent, and provider selection remain separate steps.
The Web UI and CLI support preset setup; the TUI manages existing profiles. A profile remains visible and removable if saving its key fails. Credential changes revoke both saved and running consent while a daemon restart is pending. Browser requests cannot select daemon environment variables as credentials.
Codex enrollment and transport code are included behind a disabled release gate. Sign-in, model discovery, and inference remain unavailable until a build is certified; sign-in returns HTTP 503 before changing credentials or consent. Linux CI builds include the adjacent static bridge and its linked checksum. Other distribution paths and real-artifact certification still need work before enabling Codex. Review the Codex credential lifecycle and process isolation separately from the usable HTTP presets.
Refs #917