Skip to content

Allow caller-owned interaction for SSH masters - #71

Merged
wesm merged 1 commit into
mainfrom
fix/openssh-interactive-master
Aug 16, 2026
Merged

Allow caller-owned interaction for SSH masters#71
wesm merged 1 commit into
mainfrom
fix/openssh-interactive-master

Conversation

@wesm

@wesm wesm commented Aug 16, 2026

Copy link
Copy Markdown
Member

Persistent OpenSSH masters currently force batch mode, which prevents callers with a bounded askpass or terminal policy from handling authentication.

  • Preserve noninteractive master startup by default.
  • Let an explicit caller opt into OpenSSH interaction with BatchMode=no.
  • Keep prompt discovery, transport, deadlines, and responses outside the reusable lifecycle package.
  • Document the ownership boundary as a package invariant.

OpenSSH cannot invoke a bounded askpass channel while ControlMaster startup
forces batch mode. Let callers that own an explicit interaction policy opt
out of batch mode without changing the secure default for existing users.

The reusable lifecycle layer still does not create or discover a prompt
channel. It only carries the caller's deliberate connection policy.

Generated with Codex
Co-authored-by: Codex <noreply@openai.com>
@roborev-ci

roborev-ci Bot commented Aug 16, 2026

Copy link
Copy Markdown

roborev: Combined Review (444a726)

Code looks clean; no Medium, High, or Critical findings were reported.


Reviewers: 2 done | Synthesis: codex, 9s | Total: 1m24s

@wesm
wesm merged commit a977a23 into main Aug 16, 2026
11 checks passed
@wesm
wesm deleted the fix/openssh-interactive-master branch August 16, 2026 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant