Skip to content

fix(create): handle remaining ambiguous outcomes - #337

Merged
mariusvniekerk merged 1 commit into
kenn-io:mainfrom
salmonumbrella:fix/issue-329-review-followup
Sep 3, 2026
Merged

fix(create): handle remaining ambiguous outcomes#337
mariusvniekerk merged 1 commit into
kenn-io:mainfrom
salmonumbrella:fix/issue-329-review-followup

Conversation

@salmonumbrella

@salmonumbrella salmonumbrella commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

What changed

  • Bounded look-alike retrieval and scoring to the first 500 Unicode code points of both the title and body.
  • Classified dropped connections and truncated responses as create_outcome_unknown, including platform-specific Unix and Windows failures.
  • Updated the CLI reference to describe the final matching and recovery behavior.
  • Gave the hook-dispatcher drain test enough time for sequential process starts on Windows runners.

Why

Follow-up review of #331 found additional paths that could still produce oversized look-alike queries or leave a successful create looking like a raw transport failure. Those cases need the same check-before-retry guidance so callers do not accidentally create duplicates.

Usage

No command changes are required. If kata create reports create_outcome_unknown, check whether the issue exists before retrying. Use --force-new only after confirming that no issue was created.

Follow-up to #331.

@roborev-ci

roborev-ci Bot commented Sep 3, 2026

Copy link
Copy Markdown

roborev: Combined Review (2f9d14c)

No issues found.


Reviewers: 2 done | Synthesis: codex | Total: 2m54s

@salmonumbrella
salmonumbrella force-pushed the fix/issue-329-review-followup branch from 2f9d14c to 74ab63e Compare September 3, 2026 02:56
@roborev-ci

roborev-ci Bot commented Sep 3, 2026

Copy link
Copy Markdown

roborev: Combined Review (74ab63e)

No issues found.


Reviewers: 2 done | Synthesis: codex | Total: 4m13s

@salmonumbrella
salmonumbrella force-pushed the fix/issue-329-review-followup branch from 74ab63e to bf82ede Compare September 3, 2026 03:25
@roborev-ci

roborev-ci Bot commented Sep 3, 2026

Copy link
Copy Markdown

roborev: Combined Review (bf82ede)

No issues found.


Reviewers: 2 done | Synthesis: codex | Total: 2m52s

@salmonumbrella

Copy link
Copy Markdown
Contributor Author

@wesm ready

@mariusvniekerk mariusvniekerk self-assigned this Sep 3, 2026
@mariusvniekerk
mariusvniekerk merged commit 7fa580d into kenn-io:main Sep 3, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants