Conversation
The event-driven federation test stopped its service as soon as the hub commit became visible. The spoke can still be applying the echoed event at that point, so cancellation sometimes turned normal test cleanup into a worker failure. Wait for the successful pass to clear the deliberately seeded offline error. This keeps the shutdown assertion deterministic without hiding real worker errors in Service.Run. Generated with Codex Co-authored-by: Codex <codex@openai.com>
roborev: Combined Review (
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevents the recurring
TestServiceRunWakesFederationOnCommittedEventflake by keeping the mounted service alive until its event-driven federation pass finishes.The test seeds an offline sync error, switches to the live test hub, creates an issue, and broadcasts a wake. It previously treated hub-side issue visibility as completion, but the hub commit becomes visible before the spoke pulls its echoed event. Cleanup could cancel that in-flight SQLite transaction, and
Service.Runthen surfaced the transaction failure as designed. The identical failure appeared in Tests run 982 and the pg17 job in Tests run 986.The assertion now also waits for the successful pass to clear the deliberately seeded offline error. This preserves the existing two-second event-driven boundary and leaves production shutdown and worker-error handling unchanged.
Run 986's Federation Docker failure is separate:
apt-gettimed out fetching every configured Debian index before the image could run Kata. This change leaves the image unchanged rather than adding a package-mirror workaround for a runner-network failure.