Add kata status for one-line issue ownership and lease state - #335
Merged
Conversation
roborev: Combined Review (
|
wesm
changed the title
kata status for one-line issue ownership and lease state
`kata status` reported its lease-or-ownership state under a field named `claim`. That name collides with the `kata claim` command, which sets ownership: an agent that had just run `kata claim` would read `claim=assigned` and could not tell whether its claim had worked. The field is now `hold`, with the same six values, and the docs say that a successful `kata claim` outside federation yields `hold=assigned`. `actor_source` mixed two vocabularies. When the daemon authenticated the actor it copied the principal kind, such as `db_token`; otherwise it used the client-side `whoami` sources. Readers had to consult `auth` to know which one they were looking at. A daemon-authenticated actor now reports `actor_source=daemon`, and `auth` alone carries the principal kind. The human renderer omitted the lease expiry and pending lease count that the JSON and agent modes carried, so `hold=expired` or `hold=pending` gave no time or count. It now prints both when present. Generated with Claude Code (claude-fable-5-1) Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
roborev: Combined Review (
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
kata status <ref>reports, in one call, who the daemon thinks you are and who holds an issue. Until now an agent had to combinekata whoami(client-side actor only), the fullkata showoutput, and the federation lease rules to decide whether it could safely start on an issue.The command reads the issue and the daemon's
/api/v1/instanceendpoint, then prints the issue status and revision, the effective actor, the daemon instance UID, the owner, and oneholdvalue:holdactiveexpiredpendingassignedkata claimproduces outside federationunassignedclosedWhen the daemon authenticated the actor,
actoris the daemon's principal andactor_sourceisdaemon;authcarries the principal kind. Otherwiseactor_sourceis the client-side source thatkata whoamireports. Expiry is judged against the hub clock returned with the issue when present, otherwise local time.Human,
--json, and--agentoutput carry the same fields, including lease expiry and pending lease count. The agent line has a fixed field order and includes the project name so short IDs stay unambiguous across projects. Both reference docs describe the contract.The issue body, comments, metadata, links, and lease violations stay on
kata show.