Skip to content

Remove unused external embeds - #1082

Merged
mariusvniekerk merged 3 commits into
mainfrom
t3code/remove-unused-embedded-components
Sep 11, 2026
Merged

Remove unused external embeds#1082
mariusvniekerk merged 3 commits into
mainfrom
t3code/remove-unused-embedded-components

Conversation

@mariusvniekerk

@mariusvniekerk mariusvniekerk commented Sep 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Retire the external embed integration because its former consumer no longer uses it.

  • Remove embed routes, host callbacks, injected actions, and presentation overrides.
  • Preserve desktop and mobile navigation, shared PR/issue and terminal views, and active-worktree highlighting.
  • Open Activity after project registration and cloning.

@mariusvniekerk @codex
refactor: retire unused external embeds
1da07be 
The application that needed embedded PR, issue, and workspace views no
longer consumes them. Remove the external host routes, configuration,
and callbacks so they no longer complicate application behavior.

Keep desktop and mobile navigation, shared detail and terminal views,
and daemon-provided active-worktree highlighting. Project registration
and cloning return to the standalone workspace list.

Generated with Codex
Co-authored-by: Codex <noreply@openai.com>
@roborev-ci

roborev-ci Bot commented Sep 11, 2026

Copy link
Copy Markdown

roborev: Combined Review (1da07be)

Verdict: Changes require fixes for 1 finding.

Medium

  • frontend/src/lib/components/terminal/WorkspaceFirstRunPanel.svelte:299-302: After successful project registration or cloning, the flow always navigates to /workspaces, which lists kenn-forge workspaces rather than registered projects or project worktrees. Newly registered local-only projects become inaccessible and users cannot create their first project worktree. Provide a replacement project/worktree surface and navigate to it, or expose registered projects and worktree creation from /workspaces. Add a regression assertion covering post-registration continuation.

    Reported by: codex

Reviewers: 2 done | Synthesis: codex, 9s | Total: 13m23s

mariusvniekerk and others added 2 commits September 11, 2026 13:44
@mariusvniekerk @codex
fix: open Activity after project setup
821a620 
Project registration and cloning should land in Activity after the
external embed removal. The workspace list is not the intended setup
continuation. Check the rendered Activity view after registration as
well as the destination for registration and cloning.

Generated with Codex
Co-authored-by: Codex <noreply@openai.com>
@mariusvniekerk @codex
fix: finish retiring external embed remnants
5465a90 
Remove the orphaned project-card workflow and guidance for deleted
embed controls. The retired integration does not need a replacement
project/worktree screen in the standalone application.

Keep daemon-provided active-worktree highlighting covered through the
application and pull sidebar. Hide local tooling status when intake
targets a remote host, where that status would describe the wrong machine.

Generated with Codex
Co-authored-by: Codex <noreply@openai.com>
@roborev-ci

roborev-ci Bot commented Sep 11, 2026

Copy link
Copy Markdown

roborev: Combined Review (5465a90)

No issues found.

Reviewers: 2 done | Synthesis: codex | Total: 16m28s

@mariusvniekerk
mariusvniekerk merged commit c1ed5ad into main Sep 11, 2026
17 checks passed
@mariusvniekerk
mariusvniekerk deleted the t3code/remove-unused-embedded-components branch September 11, 2026 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@mariusvniekerk