Skip to content

feat: let App clients discover repositories a page at a time - #1081

Open
wesm wants to merge 1 commit into
mainfrom
feat/app-installation-discovery
Open

feat: let App clients discover repositories a page at a time#1081
wesm wants to merge 1 commit into
mainfrom
feat/app-installation-discovery

Conversation

@wesm

@wesm wesm commented Sep 11, 2026

Copy link
Copy Markdown
Member

Let embedded callers discover GitHub App installations and repositories a page at a time, retaining stable IDs, installed accounts, repository selection mode and default branches. Callers keep control of total request budgets; existing full-list methods are unchanged.

  • Add an exact installation check that confirms the expected App before classifying absence. Suspended installations and rejected JWTs are distinct; JWT rejection does not imply that a private key was revoked.
  • Leave rate limits, server failures and other uncertain responses unclassified. Discovery itself never mints installation tokens.
  • Extend the public Account and Installation structs; external positional literals need updating.

Library only: no UI, persistence, background worker or credential-storage changes.

Embedded callers need to stop discovery within their own request budgets
without losing stable installation and repository identities. Add explicit
page reads while preserving the existing full-list methods.

Confirm the expected App before interpreting an installation 404 as absence.
Keep JWT rejection separate from key revocation, and leave rate limits and
other uncertain failures unclassified. Discovery never mints tokens.

Generated with Codex
Co-authored-by: Codex <noreply@openai.com>
@roborev-ci

roborev-ci Bot commented Sep 11, 2026

Copy link
Copy Markdown

roborev: Combined Review (1fc6c3b)

No issues found.


Reviewers: 2 done | Synthesis: codex | Total: 1m52s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant