fix: reap workspace test tmux after abrupt exits - #1040
Merged
Conversation
The split workspace test package owns one private tmux server for its full lifetime. A forced test-binary exit skips TestMain and signal cleanup, so that server could outlive its owner and consume resources in later test runs. Use the shared tmux owner with a reaper that observes owner death. Failed cleanup also terminates the reaper while preserving state for the existing stale-owner recovery path. Generated with Codex Co-authored-by: Codex <noreply@openai.com>
roborev: Combined Review (
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The split
internal/server/workspacetestpackage keeps one private tmux server for the lifetime of its test binary. A forced exit skipsTestMainand signal cleanup, so the server could outlive the test run and consume resources in later runs.This routes package-level ownership through
testtmux.Ownerand adds an owner reaper process that cleans registered servers when the parent dies. Normal cleanup stops the reaper, failed cleanup cancels it while preserving stale-owner state, and a regression test kills the owner and observes the server disappear.