fix: start dev-stack processes from a non-login shell - #1039
Merged
Conversation
process-compose ran each process through `sh -lc`. On macOS a login sh sources /etc/profile, which runs path_helper and rebuilds PATH with the system directories first and everything the user configured appended after. The dev daemon inherited that order and passed it to every agent it launched, so agents resolved `git` to Apple's /usr/bin/git even when a newer Homebrew git was installed. Apple's git predates config-based hooks, so a user's global pre-commit hooks silently never ran inside agent sessions. process-compose already inherits the caller's PATH, so a login shell added nothing. Use `sh -c` and keep the PATH the developer started the stack with. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
roborev: Combined Review (
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dev stack ran every process-compose process through
sh -lc. On macOS a loginshsources/etc/profile, which runspath_helperand rebuilds PATH with the system directories first and the developer's own entries appended after. The dev daemon inherited that order and handed it to every agent it launched, so agents picked up Apple's/usr/bin/gitahead of a newer Homebrew git. Apple's git predates config-based hooks, so global pre-commit hooks silently never ran inside agent sessions.sh -c. process-compose already inherits the caller's PATH, so the login shell added nothing.This fixes the developer stack only. A daemon started from somewhere without the user's shell environment still passes that environment to agents; resolving PATH from the login shell at agent launch is a separate change.
🤖 Generated with Claude Code