feat: sort workspaces by agent status and recency - #1037
Merged
Conversation
Maintainers need to scan agent workspaces by lifecycle outcome, especially completed runs, without searching the repository-grouped list. Use the server's attention order and keep newer workspaces first within each state. Desktop and phone workspace lists now present the same stable grouping. Generated with Codex Co-authored-by: Codex <noreply@openai.com>
Maintainers need to see why a workspace appears at its current position without opening it or comparing hidden dates. Show the active sort time below each linked-item chip. Use the hook report, terminal activity, item activity, or creation time that matches the selected view, and keep repository-grouped rows unchanged. Generated with Codex Co-authored-by: Codex <noreply@openai.com>
Rows without a linked item collapsed the right metadata column, so recency and dirty-state markers no longer shared a scan line with other workspaces. Reserve the chip footprint without presenting a fake item action. Generated with Codex Co-authored-by: Codex <noreply@openai.com>
Workspace recency labels looked smaller and more technical than the same timestamps in pull request and issue lists. Use the established metadata text treatment so maintainers can scan recency consistently across views. Generated with Codex Co-authored-by: Codex <noreply@openai.com>
Agent-status sorting needs visible group membership and must use the same hook recency shown to maintainers. Creation time can contradict the displayed order after a later hook update. Keep Idle and Unreported visible in this mode, preserve Done after row acknowledgement, and match pull request and issue timestamp typography across desktop and phone layouts. Generated with Codex Co-authored-by: Codex <noreply@openai.com>
The Agent status view can contain many workspaces that have no hook report. Repeating a placeholder on every row hides the statuses that need attention. Keep those workspaces in the final sort bucket, but leave their status area empty on desktop and phone layouts. Generated with Codex Co-authored-by: Codex <noreply@openai.com>
Maintainers use Agent status as a stable queue. Opening a completed workspace must not make its row jump or erase the completion time. Lock this behavior in the sidebar interaction contract. Completion acknowledgement remains limited to the other sort modes. Generated with Codex Co-authored-by: Codex <noreply@openai.com>
This comment has been minimized.
This comment has been minimized.
Workspace recency should not disappear because a row lacks a linked pull request or issue. Phone rows tied timestamp rendering to the item chip, and Agent status rows without a hook report hid the creation fallback used for ordering. Render those fallback times independently while keeping the unreported agent status unlabeled. Addresses both Medium findings in roborev-ci comment #1037 (comment) and local roborev job 13603 at c6d929b. Generated with Codex Co-authored-by: Codex <noreply@openai.com>
roborev: Combined Review (
|
Workspaces without a hook report can still have recent pull request or issue activity. Ordering those rows by creation alone hides that newer provider activity. Use item activity before creation time for both the Agent status order and its unlabeled relative timestamp. Generated with Codex Co-authored-by: Codex <noreply@openai.com>
This comment has been minimized.
This comment has been minimized.
Agent status is a stable queue for completed workspaces. Opening a completed workspace from that view must not acknowledge it and hide its Done state after the maintainer switches to another sort mode. Keep completion acknowledgement limited to navigation from the other sort modes so the visible state matches the action that recorded it. Generated with Codex Co-authored-by: Codex <noreply@openai.com>
This comment has been minimized.
This comment has been minimized.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.