fix: show committers for rebased commits - #1036
Merged
Merged
Conversation
The commit normalization test should verify metadata content without depending on JSON formatting. Use Testify's JSON assertion so repository lint accepts the test and equivalent encodings remain valid. Generated with Codex Co-authored-by: Codex <noreply@openai.com>
roborev: Combined Review (
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub commit events now keep author and committer identities and timestamps separate through normalization, persistence, and timeline rendering. Rebased commits display the committer login or Git signature name and use the committed timestamp when available, while commit metadata retains the original author. Missing committer fields fall back independently to the author identity and authored time. Other providers keep their current normalization.
Coverage exercises REST normalization, GraphQL bulk sync and nullable timestamps, metadata preservation, and compact timeline rendering. The normalization test compares metadata as JSON to follow the repository's lint contract. No schema or generated-client change is needed.
Closes #83
generated by a clanker