Skip to content

feat: send follow-up prompts to live agent runtimes - #1035

Merged
mariusvniekerk merged 2 commits into
mainfrom
feat/mcp-follow-up-runtime-prompts
Sep 4, 2026
Merged

feat: send follow-up prompts to live agent runtimes#1035
mariusvniekerk merged 2 commits into
mainfrom
feat/mcp-follow-up-runtime-prompts

Conversation

@mariusvniekerk

Copy link
Copy Markdown
Collaborator

MCP clients can now send a follow-up prompt to an existing live agent runtime using its workspace ID and runtime session key.

  • Reuses the serialized bracketed-paste and Enter path used for the initial prompt.
  • Rejects targets that are not live agent runtimes.
  • Returns after submission without launching, persisting, resuming, or waiting for activity.

MCP clients could launch an agent with an initial prompt but had no supported
way to continue that same live runtime later. Expose the existing serialized
runtime input path as a send-and-forget operation, without adding persistence,
session resumption, or activity tracking.

Generated with Codex
Co-authored-by: Codex <noreply@openai.com>
@roborev-ci

roborev-ci Bot commented Sep 4, 2026

Copy link
Copy Markdown

roborev: Combined Review (d743e99)

Verdict: One medium-severity issue remains regarding ambiguous follow-up delivery outcomes.

  • Mediuminternal/server/workspaceapi/initial_message.go:217-224, internal/server/mcp_backend.go:648-650: Follow-up writes may continue after the caller’s context times out, causing the response to report failure even though the prompt is later delivered. Because this is classified as a non-retryable, non-ambiguous internal_error, retries may submit the same follow-up twice. Classify post-write/context-timeout failures as an ambiguous mutation outcome, such as via mcpBackendMutationError or a dedicated mutationOutcomeUnknown error.

Reviewers: 2 done | Synthesis: codex, 8s | Total: 5m50s

Persistent-config server tests run the real config watcher. The worktree-base
test read the server config while that watcher could replace it after a saved
update, which made the race test fail under load. Take each assertion snapshot
under the config mutex used by the watcher.

Generated with Codex
Co-authored-by: Codex <noreply@openai.com>
@roborev-ci

roborev-ci Bot commented Sep 4, 2026

Copy link
Copy Markdown

roborev: Combined Review (c0dda73)

Verdict: One medium-severity issue found; otherwise the changes look sound.

Medium

  • internal/server/mcp_backend.go:648-649: Write or timeout failures may occur after a prompt has been partially or fully sent, but this path maps them to an unambiguous MCP error. Callers cannot safely determine whether retrying could submit a duplicate prompt. Mark unknown terminal-write outcomes as ambiguous (for example, via mcpBackendMutationError(err)) and add coverage for this failure path.

Reviewers: 2 done | Synthesis: codex, 7s | Total: 6m29s

@mariusvniekerk
mariusvniekerk merged commit 47a762d into main Sep 4, 2026
16 checks passed
@mariusvniekerk
mariusvniekerk deleted the feat/mcp-follow-up-runtime-prompts branch September 4, 2026 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant