docs: correct backup.md blob reference description - #277
Open
rodboev wants to merge 1 commit into
Open
Conversation
Backup captures blobs referenced by the BackupBlobAuthorityCTE tables, not every blobs row; unreferenced GC candidates are excluded. Closes kenn-io#264
roborev: Combined Review (
|
rodboev
changed the title
rodboev
marked this pull request as ready for review
September 4, 2026 14:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docs/architecture/backup.mdsaid backup captures everyblobsrow, "including a row that has become a GC candidate but has not yet been reclaimed." Backup capture is actually scoped toBackupBlobAuthorityCTE(internal/store/metadata.go:266-278), which UNIONs blobs referenced bycontent_versions,rendition_artifacts,visual_preview_generations,rendition_builds, andrendition_jobs. An unreferenced blob (a GC candidate by definition) is excluded.Docs-only. Two spots corrected so the file is internally consistent:
blobsrow") now reads "the backup-authorized blob closure," matching the CTE.Opened as draft only because of the 6-PR limit; ready to review.
Closes #264