feat(ingest): add glob selection to local ingest - #272
Open
rodboev wants to merge 12 commits into
Open
Conversation
Carry include and exclude rules through preflight, ingest, and CLI while preserving watcher literal matching and daemon boundaries.
Carry include and exclude rules through preflight, ingest, and CLI while preserving watcher literal matching and daemon boundaries.
Carry include and exclude rules through preflight, ingest, and CLI while preserving watcher literal matching and daemon boundaries.
roborev: Combined Review (
|
roborev: Combined Review (
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ingest can now select files from a mixed source tree with include and exclude patterns. Preflight, ordinary ingest, streamed ingest, and the command-line report use the same selection rules, so a matching file is counted and imported consistently.
Exclusions take precedence, directories remain traversable when only a descendant can match, and empty include rules preserve the current behavior. Patterns use the standard path-matching grammar and stay scoped to the requested source tree; watched-inbox exclusions remain literal. Existing
--excludevalues now use glob matching; use bracket expressions such asreport[[]1].txtfor literal metacharacters.The issue report came from a workflow that had to enumerate exclusions in a mixed tree to keep one import report and provenance record. This change covers glob source selection only; the separate per-file size budget and add replacement behavior remain outside the scope.
Refs #197.