fix(frontend): render retained tool-result images - #1738
Open
rodboev wants to merge 2 commits into
Open
Conversation
roborev: Combined Review (
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Formatted tool output renders retained Codex PNG results between surrounding text and keeps large payloads within the output pane. Image-only results render as images, and Raw keeps retained inline results available for inspection.
The frontend projects retained input_image data URIs for PNG, JPEG, WebP, and GIF through the existing Markdown renderer and asset resolver. Migrated asset references keep their current behavior. Unsupported media, malformed blocks, and remote URLs remain stored text. The change stays in ToolBlock and its display helper, with no backend, storage, configuration, or locale changes.
PR #1729 covers ingest-time offload. This change covers retained inline images in Keep mode.
The reproduction came from #1735. It measured 10,812,829 pixels of horizontal scroll in a 1,623 pixel box, with zero image elements. Focused tests and Chromium proof cover the change and browser smoke tests confirm the fix.
Closes #1735