Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parsing of seven-column /proc/modules #595

Open
wants to merge 7 commits into
base: dev
Choose a base branch
from

Conversation

psfrolov
Copy link

In modern Linux distributions (e.g. Ubuntu 22.04 and newer) /proc/modules contain seven columns. The seventh column denotes module taint state.

kellyjonbrazil and others added 3 commits March 23, 2024 11:11
In modern Linux distributions (e.g. Ubuntu 22.04 and newer) `/proc/modules` contain seven columns. The seventh column denotes module taint state.
@kellyjonbrazil
Copy link
Owner

Nice, thanks for the contribution!

@kellyjonbrazil kellyjonbrazil changed the base branch from master to dev September 23, 2024 17:13
@kellyjonbrazil
Copy link
Owner

Do you have test in/out files you can add to tests/fixtures/linux-proc and could you add a test case to tests/test_proc_modules.py?

@psfrolov
Copy link
Author

psfrolov commented Oct 30, 2024

Do you have test in/out files you can add to tests/fixtures/linux-proc and could you add a test case to tests/test_proc_modules.py?

I can collect input data and parsing result from Ubuntu machine for new test case

Also a question regarding existing (failed) tests: should I fix existing tests by adding taint_state: None to expected test result, or should I modify the parser code itself so to avoid taint_state in parser result object altogether if taint_state column is absent from cat /proc/modules output? (The later seems more appropriate)

@kellyjonbrazil
Copy link
Owner

Could you modify the code so taint_state only shows up if it exists? Thanks!

@kellyjonbrazil kellyjonbrazil added question Further information is requested reviewing and removed question Further information is requested labels Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants