Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update aws-sdk-go-cache to v0.0.2 #399

Merged
merged 1 commit into from
Oct 24, 2023
Merged

Update aws-sdk-go-cache to v0.0.2 #399

merged 1 commit into from
Oct 24, 2023

Conversation

tekenstam
Copy link
Member

No description provided.

@tekenstam tekenstam requested review from a team as code owners October 24, 2023 17:45
@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Merging #399 (34f0c8f) into master (4c5949f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #399   +/-   ##
=======================================
  Coverage   39.09%   39.09%           
=======================================
  Files           7        7           
  Lines         931      931           
=======================================
  Hits          364      364           
  Misses        540      540           
  Partials       27       27           
Flag Coverage Δ
unittests 39.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tekenstam tekenstam merged commit 7c245ca into master Oct 24, 2023
4 checks passed
@tekenstam tekenstam deleted the update-deps branch October 24, 2023 17:53
@shreyas-badiger shreyas-badiger mentioned this pull request Oct 30, 2023
shreyas-badiger added a commit that referenced this pull request Dec 5, 2023
* early-cordon nodes

Signed-off-by: sbadiger <[email protected]>

* early cordon

Signed-off-by: sbadiger <[email protected]>

* include context in cordon and drain functions

* cordon only drifted instances

* add unit tests

* Update aws-sdk-go-cache to v0.0.2 (#399)

Signed-off-by: Todd Ekenstam <[email protected]>
Signed-off-by: sbadiger <[email protected]>

* Process drain-failure nodes at the end (#394)

* Process drain-failures at the end
Signed-off-by: ssheladiya <[email protected]>
Signed-off-by: sbadiger <[email protected]>

* early-cordon nodes

Signed-off-by: sbadiger <[email protected]>

* early cordon

Signed-off-by: sbadiger <[email protected]>

* include context in cordon and drain functions

Signed-off-by: sbadiger <[email protected]>

* Release v1.0.8 (#400)

Signed-off-by: sbadiger <[email protected]>

* cordon only drifted instances

Signed-off-by: sbadiger <[email protected]>

* add unit tests

Signed-off-by: sbadiger <[email protected]>

* resolve merge conflicts

* update go.sum

* resolve test errors

* remove cordon as upgrade strategy

* remove space

* improve test coverage

* improve code coverage

* remove redundant code

* remove unused imports

* Update controllers/providers/kubernetes/nodes.go

Co-authored-by: Venkata Gunapati <[email protected]>

* uncordon the nodes

* error handling for uncordoning

* add tests

* handle uncordon scenario properly

* Update controllers/providers/kubernetes/nodes.go

Co-authored-by: Venkata Gunapati <[email protected]>

* fix typo

* fix lint errors

* default the feature to false

---------

Signed-off-by: sbadiger <[email protected]>
Signed-off-by: Todd Ekenstam <[email protected]>
Co-authored-by: Todd Ekenstam <[email protected]>
Co-authored-by: Siddharth Sheladiya <[email protected]>
Co-authored-by: Venkata Gunapati <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant