fix: modified UniformAcrossAzUpdateStrategy update strategy to be as expected #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccpeng
force-pushed
the
uniformupdatestrategy
branch
from
0931a2a to
a2adb6b
Compare
…expected Signed-off-by: Chun-Che Peng <[email protected]>
ccpeng
force-pushed
the
uniformupdatestrategy
branch
from
a2adb6b to
70a18e2
Compare
Codecov Report
@@ Coverage Diff @@
## master #395 +/- ##
=======================================
Coverage 39.09% 39.09%
=======================================
Files 7 7
Lines 931 931
=======================================
Hits 364 364
Misses 540 540
Partials 27 27
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
shreyas-badiger
approved these changes
Oct 23, 2023
ZihanJiang96
approved these changes
Oct 23, 2023
|
LGTM |
tekenstam
approved these changes
Oct 24, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #349
the README has a broken link to
uniform_across_az_update_strategy.yamlbut I think this is the intended behavior