fix: Allow filtering incidents by is_visible status #5377
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes the hardcoded `is_visible == True` filter from the base incident query when an explicit `is_visible` filter is provided via CEL. This allows querying for non-visible incidents (e.g., `is_visible == false`). Fixes keephq#5376
|
@subha0319 is attempting to deploy a commit to the KeepHQ Team on Vercel. A member of the Team first needs to authorize it. |
dosubot
bot
added
the
size:M
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the hardcoded
is_visible == Truefilter from the base incident query when an explicitis_visiblefilter is provided via CEL. This allows querying for non-visible incidents (e.g.,is_visible == false).Fixes #5376
Closes #
📑 Description
✅ Checks
ℹ Additional Information