-
Notifications
You must be signed in to change notification settings - Fork 936
fix: enhance TextField component to handle sensitive configuration #4418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: enhance TextField component to handle sensitive configuration #4418
Conversation
@tuantran0910 is attempting to deploy a commit to the KeepHQ Team on Vercel. A member of the Team first needs to authorize it. |
@tuantran0910 let's make it optional with some environment variable? I don't want to change the default behaviour |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comment
…S in configuration documentation
@tuantran0910 yea so in Keep we do not use |
Hi @shahargl, can you review this again ? I have modified the environment variable name, also added it in |
Sorry, seems that it is still not working, which made the test failed, will resolve asap. |
It's fine now :D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Closes #4417
📑 Description
In the provider configuration UI, sensitive fields such as
bot_token
(e.g., in the Telegram provider) are correctly rendered withtype="password"
to hide their values. However, the actual token value is still visible in the DOM (e.g., through browser dev tools), defeating the purpose of marking it as sensitive.Before:
After:
✅ Checks