-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Prototype] Node grouping #4427
Open
ankatiyar
wants to merge
7
commits into
main
Choose a base branch
from
grouping
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
2ff33b2
Add deployment related attributes
ankatiyar 0d6461a
Merge branch 'main' into grouping
ankatiyar ef4d664
Update with feedback
ankatiyar a299ef3
Minor formatting
ankatiyar b79f1f5
Add test
ankatiyar a8b1f45
Update test
ankatiyar 9d736b9
Merge branch 'main' into grouping
ankatiyar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -369,6 +369,31 @@ def grouped_nodes(self) -> list[list[Node]]: | |
|
||
return [list(group) for group in self._toposorted_groups] | ||
|
||
@property | ||
def grouped_nodes_by_namespace(self) -> dict[str, dict[str, Any]]: | ||
"""Return a dictionary of the pipeline nodes grouped by namespace with | ||
information about the nodes, their type, and dependencies.""" | ||
grouped_nodes: dict[str, dict[str, Any]] = defaultdict(dict) | ||
for node in self.nodes: | ||
key = node.namespace or node.name | ||
if key not in grouped_nodes: | ||
grouped_nodes[key] = {} | ||
grouped_nodes[key]["name"] = key | ||
grouped_nodes[key]["type"] = "namespace" if node.namespace else "node" | ||
grouped_nodes[key]["nodes"] = [*grouped_nodes[key].get("nodes", []), node] | ||
dependencies = set() | ||
for parent in self.node_dependencies[node]: | ||
if parent.namespace and parent.namespace != key: | ||
dependencies.add(parent.namespace) | ||
elif parent.namespace and parent.namespace == key: | ||
continue | ||
else: | ||
dependencies.add(parent.name) | ||
grouped_nodes[key]["dependencies"] = ( | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. And here is the same as the above |
||
grouped_nodes[key].get("dependencies", set()) | dependencies | ||
) | ||
return grouped_nodes | ||
|
||
def only_nodes(self, *node_names: str) -> Pipeline: | ||
"""Create a new ``Pipeline`` which will contain only the specified | ||
nodes by name. | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we have O(Nˆ2) complexity here, as every time we add a node, we recreate a list based on what was already there. So maybe it makes sense to initialize
grouped_nodes[key]["nodes"]
and then just append to it.