feat(all): Replace trufflehog with detect-secrets #983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Elena Khaustova <[email protected]>
Signed-off-by: Elena Khaustova <[email protected]>
Signed-off-by: Elena Khaustova <[email protected]>
ElenaKhaustova
changed the title
ElenaKhaustova
changed the title
Signed-off-by: Elena Khaustova <[email protected]>
Signed-off-by: Elena Khaustova <[email protected]>
Signed-off-by: Elena Khaustova <[email protected]>
Signed-off-by: Elena Khaustova <[email protected]>
Signed-off-by: Elena Khaustova <[email protected]>
Signed-off-by: Elena Khaustova <[email protected]>
ElenaKhaustova
requested review from
DimedS,
merelcht,
ravi-kumar-pilla and
ankatiyar
Signed-off-by: Elena Khaustova <[email protected]>
merelcht
approved these changes
Jan 13, 2025
Signed-off-by: Elena Khaustova <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Solves kedro-org/kedro#4062 for plugins
In this PR we replace trufflehog with detect-secrets - https://github.com/Yelp/detect-secrets for secrets detecting locally and at the CI.
Extended
validate-pr-title.yamlscopes withallto handle cases when changes are applied to all plugins.Development notes
Please see notes for the similar PR for the framework: kedro-org/kedro#4404
Example of check failing for plugin at the CI: https://github.com/kedro-org/kedro-plugins/actions/runs/12745897204/job/35520826972?pr=983
Checklist
jsonschema/kedro-catalog-X.XX.jsonif necessaryRELEASE.mdfile