chore(datasets): Remove deprecation warning from Table Dataset

[ravi-kumar-pilla]

Description

Remove deprecation warning as suggested here - Need to remove code that's marked as "to be removed": ibis dataset: https://github.com/kedro-org/kedro-plugins/blob/main/kedro-datasets/kedro_datasets/ibis/table_dataset.py#L123-L128

Development notes

• Removed the deprecation warning from Table Dataset
• Updated release note

Checklist

• Opened this PR as a 'Draft Pull Request' if it is work-in-progress
• Updated the documentation to reflect the code changes
• Added a description of this change in the relevant RELEASE.md file
• Added tests to cover my changes
• Received approvals from at least half of the TSC (required for adding a new, non-experimental dataset)

[merelcht]

@deepyaman should filepath and file_format also be removed as arguments? I see in the history that you did remove them from the docstrings already.

[deepyaman]

@deepyaman should filepath and file_format also be removed as arguments? I see in the history that you did remove them from the docstrings already.

Yes, please!

[ravi-kumar-pilla]

Yes, please!

Hi @deepyaman , I may not be fully aware of the context but what happens to the load function if we remove the parameters filepath and file_format ? I see a docstring mentioning this

So to summarize, this will affect 2 functions load and _describe. For _describe I can remove the keys from the returned dict. I am not clear on load

Thank you

[deepyaman]

Yes, please!

Hi @deepyaman , I may not be fully aware of the context but what happens to the load function if we remove the parameters filepath and file_format ? I see a docstring mentioning this

So to summarize, this will affect 2 functions load and _describe. For _describe I can remove the keys from the returned dict. I am not clear on load

Thank you

All this logic can be removed; ibis.FileDataset should fully cover these functionalities.

        if self._filepath is not None:
            if self._file_format is None:
                raise NotImplementedError
            reader = getattr(self.connection, f"read_{self._file_format}")
            return reader(self._filepath, self._table_name, **self._load_args)

        else:

[deepyaman]

Will re-review after #909 is merged and this is up to date; don't think load args needs to be removed altogether.

[deepyaman]

Nevermind, I reviewed it.

[deepyaman]

This largely looks good to me!

One more change that probably should be added is including the removal (and directions to use FileDataset instead) in the release notes.

Since this is pretty much good, I wouldn't bother with making the changes (for the most part) until #909 gets merged and this is rebased.

[deepyaman]

Approving, only minor suggestions

[ankatiyar]

LGTM!