Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Separated the Lint Dependencies for the Plugins #901

Merged
12 changes: 6 additions & 6 deletions .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,14 +34,14 @@ jobs:
python -m pip install "uv==0.2.21"
- name: Install dependencies
run: |
cd ${{ inputs.plugin }}
uv pip install --system "kedro @ git+https://github.com/kedro-org/kedro@main"
uv pip install --system "${{inputs.plugin}}[test] @ ."
uv pip freeze --system
cd ${{ inputs.plugin }}
uv pip install --system "kedro @ git+https://github.com/kedro-org/kedro@main"
uv pip install --system "${{inputs.plugin}}[lint] @ ."
uv pip freeze --system
- name: Install pre-commit hooks
run: |
pre-commit install --install-hooks
pre-commit install --hook-type pre-push
pre-commit install --install-hooks
pre-commit install --hook-type pre-push
- name: Run linter
run: make plugin=${{ inputs.plugin }} lint
- name: Run mypy
Expand Down
3 changes: 3 additions & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,9 @@ secret-scan:
install-test-requirements:
cd $(plugin) && uv pip install ".[test]"

install-lint-requirements:
cd $(plugin) && uv pip install ".[lint]"

install-pre-commit:
pre-commit install --install-hooks

Expand Down
13 changes: 8 additions & 5 deletions kedro-airflow/pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -25,20 +25,23 @@ Tracker = "https://github.com/kedro-org/kedro-plugins/issues"
[project.optional-dependencies]
test = [
"apache-airflow<3.0",
"bandit",
"behave",
"black~=22.0",
"coverage>=7.2.0",
"kedro-datasets",
"mypy~=1.0",
"pre-commit>=2.9.2",
"pytest",
"pytest-cov",
"pytest-mock",
"pytest-xdist",
"wheel",
]

lint = [
"bandit",
"black~=22.0",
"mypy~=1.0",
"pre-commit>=2.9.2",
"trufflehog>=2.1.0, <3.0",
"ruff~=0.0.290",
"wheel",
# mypy requirements
"types-PyYAML",
"types-cachetools",
Expand Down
22 changes: 13 additions & 9 deletions kedro-datasets/pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -203,11 +203,8 @@ docs = [
test = [
"accelerate<0.32", # Temporary pin
"adlfs~=2023.1",
"bandit>=1.6.2, <2.0",
"behave==1.2.6",
"biopython~=1.73",
"blacken-docs==1.9.2",
"black~=22.0",
"cloudpickle<=2.0.0",
"compress-pickle[lz4]~=2.1.0",
"coverage>=7.2.0",
Expand All @@ -222,7 +219,6 @@ test = [
"hdfs>=2.5.8, <3.0",
"holoviews>=1.13.0",
"ibis-framework[duckdb,examples]",
"import-linter[toml]==1.2.6",
"ipython>=7.31.1, <8.0",
"Jinja2<3.2.0",
"joblib>=0.14",
Expand All @@ -232,7 +228,6 @@ test = [
"matplotlib>=3.5, <3.6",
"memory_profiler>=0.50.0, <1.0",
"moto==5.0.0",
"mypy~=1.0",
"networkx~=2.4",
"opencv-python~=4.5.5.64",
"openpyxl>=3.0.3, <4.0",
Expand All @@ -241,7 +236,6 @@ test = [
"Pillow~=10.0",
"plotly>=4.8.0, <6.0",
"polars[xlsx2csv, deltalake]~=0.18.0",
"pre-commit>=2.9.2",
"pyarrow>=1.0; python_version < '3.11'",
"pyarrow>=7.0; python_version >= '3.11'", # Adding to avoid numpy build errors
"pyodbc~=5.0",
Expand All @@ -254,7 +248,6 @@ test = [
"redis~=4.1",
"requests-mock~=1.6",
"requests~=2.20",
"ruff~=0.0.290",
"s3fs>=2021.04",
"snowflake-snowpark-python~=1.0; python_version < '3.11'",
"scikit-learn>=1.0.2,<2",
Expand All @@ -265,13 +258,24 @@ test = [
"tensorflow-macos~=2.0; platform_system == 'Darwin' and platform_machine == 'arm64'",
"tensorflow~=2.0; platform_system != 'Darwin' or platform_machine != 'arm64'",
"triad>=0.6.7, <1.0",
"trufflehog~=2.1",
"xarray>=2023.1.0",
"xlsxwriter~=1.0",
# huggingface
"datasets",
"huggingface_hub",
"transformers[torch]",
]

# Lint requirements
lint = [
"bandit>=1.6.2, <2.0",
"blacken-docs==1.9.2",
"black~=22.0",
"import-linter[toml]==1.2.6",
"mypy~=1.0",
"pre-commit>=2.9.2",
"ruff~=0.0.290",
"trufflehog~=2.1",
# mypy related dependencies
"types-cachetools",
"types-PyYAML",
Expand All @@ -297,7 +301,7 @@ experimental = [
]

# All requirements
all = ["kedro-datasets[test,docs]"]
all = ["kedro-datasets[test,docs,lint]"]

[project.urls]
Source = "https://github.com/kedro-org/kedro-plugins/tree/main/kedro-datasets"
Expand Down
15 changes: 9 additions & 6 deletions kedro-docker/pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -24,22 +24,25 @@ Tracker = "https://github.com/kedro-org/kedro-plugins/issues"

[project.optional-dependencies]
test = [
"bandit",
"behave",
"black~=22.0",
"coverage>=7.2.0",
"docker",
"mypy~=1.0",
"pre-commit>=2.9.2",
"psutil",
"pytest",
"pytest-cov",
"pytest-mock",
"pytest-xdist[psutil]~=2.2.1",
"PyYAML>=5.1, <7.0",
"trufflehog>=2.0.99, <3.0",
"wheel==0.32.2",
]

lint = [
"bandit",
"black~=22.0",
"mypy~=1.0",
"pre-commit>=2.9.2",
"trufflehog>=2.1.0, <3.0",
"ruff~=0.0.290",
"wheel==0.32.2"
]

[project.entry-points."kedro.project_commands"]
Expand Down
13 changes: 8 additions & 5 deletions kedro-telemetry/pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -24,18 +24,21 @@ Tracker = "https://github.com/kedro-org/kedro-plugins/issues"

[project.optional-dependencies]
test = [
"bandit>=1.6.2, <2.0",
"black~=22.0",
"mypy~=1.0",
"pre-commit>=2.9.2",
"pytest",
"pytest-cov",
"pytest-mock",
"pytest-xdist[psutil]~=2.2.1",
"PyYAML==5.3.1", # Temporary fix, to be removed
"wheel",
]

lint = [
"bandit>=1.6.2, <2.0",
"black~=22.0",
"mypy~=1.0",
"pre-commit>=2.9.2",
"trufflehog>=2.1.0, <3.0",
"ruff~=0.0.290",
"wheel",
# mypy requirements
"types-requests",
"types-PyYAML",
Expand Down
Loading