Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datasets): fix docs build and Hive support #767

Closed
wants to merge 1 commit into from

Conversation

DimedS
Copy link
Member

@DimedS DimedS commented Jul 16, 2024

Description

Fix CI errors for docs and Hive support

Checklist

  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the relevant RELEASE.md file
  • Added tests to cover my changes

Signed-off-by: Dmitry Sorokin <[email protected]>
@astrojuanlu
Copy link
Member

Whatever this was fixing, looks like it's no longer needed?

@DimedS
Copy link
Member Author

DimedS commented Aug 21, 2024

Apologies for forgetting to remove that PR. In this PR, I encountered an issue with the CI tests and added .HiveSupport() to address it. However, Nok explained that the issue was likely due to flaky tests, so I tried a separate PR without the changes. I'll go ahead and remove that PR.

@DimedS DimedS closed this Aug 21, 2024
@astrojuanlu astrojuanlu deleted the fix-telemetry-docs-and-hive branch August 21, 2024 17:10
@astrojuanlu
Copy link
Member

FWIW, I think addressing the flaky tests is still worth our time. Let's continue that discussion at #755

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants