fix(datasets): Relax pandas.HDFDataSet dependencies which are broken …

…on Windows (#426) * Relax pandas.HDFDataSet dependencies which are broken on Window (#402) Signed-off-by: Yolan Honoré-Rougé <[email protected]> * Update RELEASE.md Signed-off-by: Yolan Honoré-Rougé <[email protected]> * Apply suggestions from code review Signed-off-by: Merel Theisen <[email protected]> * Update kedro-datasets/setup.py Signed-off-by: Merel Theisen <[email protected]> --------- Signed-off-by: Yolan Honoré-Rougé <[email protected]> Signed-off-by: Merel Theisen <[email protected]> Co-authored-by: Merel Theisen <[email protected]>
kedro-org · Jan 4, 2024 · ad67ae9 · ad67ae9
1 parent b359ca6
commit ad67ae9
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 8 deletions.
diff --git a/kedro-datasets/RELEASE.md b/kedro-datasets/RELEASE.md
@@ -1,6 +1,7 @@
 # Upcoming Release
 ## Major features and improvements
 ## Bug fixes and other changes
+* Removed Windows specific conditions in `pandas.HDFDataset` extra dependencies
 ## Community contributions
 
 # Release 2.0.0

diff --git a/kedro-datasets/setup.py b/kedro-datasets/setup.py
@@ -48,8 +48,7 @@ def _collect_requirements(requires):
     ],
     "pandas.HDFDataset": [
         PANDAS,
-        "tables~=3.6.0; platform_system == 'Windows'",
-        "tables~=3.6; platform_system != 'Windows'",
+        "tables~=3.6",
     ],
     "pandas.JSONDataset": [PANDAS],
     "pandas.ParquetDataset": [PANDAS, "pyarrow>=6.0"],
@@ -66,14 +65,23 @@ def _collect_requirements(requires):
 }
 polars_require = {
     "polars.CSVDataset": [POLARS],
-    "polars.EagerPolarsDataset":
-    [
-        POLARS, "pyarrow>=4.0", "xlsx2csv>=0.8.0", "deltalake >= 0.6.2"
+    "polars.GenericDataset": [
+        POLARS,
+        "pyarrow>=4.0",
+        "xlsx2csv>=0.8.0",
+        "deltalake >= 0.6.2",
     ],
-    "polars.LazyPolarsDataset":
-    [
+    "polars.EagerPolarsDataset": [
+        POLARS,
+        "pyarrow>=4.0",
+        "xlsx2csv>=0.8.0",
+        "deltalake >= 0.6.2",
+    ],
+    "polars.LazyPolarsDataset": [
         # Note: there is no Lazy read Excel option, so we exclude xlsx2csv here.
-        POLARS, "pyarrow>=4.0", "deltalake >= 0.6.2"
+        POLARS,
+        "pyarrow>=4.0",
+        "deltalake >= 0.6.2",
     ],
 }
 redis_require = {"redis.PickleDataset": ["redis~=4.1"]}