Skip to content

Commit

Permalink
chore(datasets): Demote VideoDataset to experimental datasets (#916)
Browse files Browse the repository at this point in the history
* Move VideoDataset to experimental datasets

Signed-off-by: Merel Theisen <[email protected]>

* Fix lint

Signed-off-by: Merel Theisen <[email protected]>

* Fix docs

Signed-off-by: Merel Theisen <[email protected]>

* Clean up

Signed-off-by: Merel Theisen <[email protected]>

* Update release notes

Signed-off-by: Merel Theisen <[email protected]>

---------

Signed-off-by: Merel Theisen <[email protected]>
  • Loading branch information
merelcht authored Oct 29, 2024
1 parent 59dcf50 commit 9ec295a
Show file tree
Hide file tree
Showing 16 changed files with 9 additions and 8 deletions.
3 changes: 2 additions & 1 deletion kedro-datasets/RELEASE.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Upcoming Release
# Upcoming Release 6.0.0

## Major features and improvements

Expand All @@ -15,6 +15,7 @@
- Implemented Snowflake's (local testing framework)[https://docs.snowflake.com/en/developer-guide/snowpark/python/testing-locally] for testing purposes

## Breaking Changes
- Demoted `video.VideoDataset` from core to experimental dataset.

## Community contributions

Expand Down
1 change: 0 additions & 1 deletion kedro-datasets/docs/source/api/kedro_datasets.rst
Original file line number Diff line number Diff line change
Expand Up @@ -64,5 +64,4 @@ kedro_datasets
text.TextDataset
tracking.JSONDataset
tracking.MetricsDataset
video.VideoDataset
yaml.YAMLDataset
Original file line number Diff line number Diff line change
Expand Up @@ -20,3 +20,4 @@ kedro_datasets_experimental
prophet.ProphetModelDataset
pytorch.PyTorchDataset
rioxarray.GeoTIFFDataset
video.VideoDataset
2 changes: 1 addition & 1 deletion kedro-datasets/docs/source/conf.py
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@
"pyspark.sql.dataframe.DataFrame",
"scipy.sparse._csr.csr_matrix",
"keras.src.models.model.Model",
"kedro_datasets.video.video_dataset.AbstractVideo",
"kedro_datasets_experimental.video.video_dataset.AbstractVideo",
"langchain_anthropic.chat_models.ChatAnthropic",
"langchain_cohere.chat_models.ChatCohere",
"xarray.core.dataset.Dataset",
Expand Down
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
10 changes: 5 additions & 5 deletions kedro-datasets/pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -167,9 +167,6 @@ tracking-jsondataset = []
tracking-metricsdataset = []
tracking = ["kedro-datasets[tracking-jsondataset, tracking-metricsdataset]"]

video-videodataset = ["opencv-python~=4.5.5.64"]
video = ["kedro-datasets[video-videodataset]"]

yaml-yamldataset = ["kedro-datasets[pandas-base]", "PyYAML>=4.2, <7.0"]
yaml = ["kedro-datasets[yaml-yamldataset]"]

Expand All @@ -192,6 +189,9 @@ pytorch = ["kedro-datasets[pytorch-dataset]"]
rioxarray-geotiffdataset = ["rioxarray>=0.15.0"]
rioxarray = ["kedro-datasets[rioxarray-geotiffdataset]"]

video-videodataset = ["opencv-python~=4.5.5.64"]
video = ["kedro-datasets[video-videodataset]"]

# Docs requirements
docs = [
"kedro-sphinx-theme==2024.10.2",
Expand Down Expand Up @@ -230,7 +230,6 @@ test = [
"moto==5.0.0",
"networkx~=2.4",
"numpy<2",
"opencv-python~=4.5.5.64",
"openpyxl>=3.0.3, <4.0",
"pandas-gbq>=0.12.0",
"pandas>=2.0",
Expand Down Expand Up @@ -298,6 +297,7 @@ experimental = [
"xarray>=2023.1.0",
"rioxarray",
"torch",
"opencv-python~=4.5.5.64",
"prophet>=1.1.5",
]

Expand Down Expand Up @@ -349,7 +349,7 @@ select = [
ignore = ["E501"] # Black takes care of line-too-long

[tool.ruff.per-file-ignores]
"{tests,docs}/*" = ["PLR2004", "PLR0913", "T201"]
"{tests,docs,kedro_datasets_experimental/tests}/*" = ["PLR2004", "PLR0913", "T201"]
"*/{__init__.py}" = ["F821"] # temporarily ignore ruff undefined name errors for dataset aliases

[tool.mypy]
Expand Down

0 comments on commit 9ec295a

Please sign in to comment.