Add support for initialCooldownPeriod On httpScaledObjects

[shayrybak]

Add support for initialCooldownPeriod On httpScaledObjects

Checklist

• Commits are signed with Developer Certificate of Origin (DCO)
• Changelog has been updated and is aligned with our changelog requirements
• Any necessary documentation is added, such as:
  • README.md
  • The docs/ directory
  • The docs repo

Fixes #1213

[wozniakjan]

lgtm, thank you! Can you please also re-generate the CRDs?

make manifests

[shayrybak]

@wozniakjan added, I always forget that part.

[wozniakjan]

perfect, thank you. One more thing, can you please sign the last commit?

[zroubalik]

Should we really do this? We could easily end up in 1-1 relation with ScaledObject's field, I wonder whether we should users encourage to specify this on the SO directly 🤔

[wozniakjan]

Should we really do this?

given this can affect scaling right after SO creation, before metrics had a chance to get to KEDA and can lead to an immediate scale to 0 on an active deployment that was just onboarded to autoscaling, I think there is a stronger case for having initialCooldownPeriod in HSO than cooldownPeriod which is already there. The cooldownPeriod could be easily changed after HSO creation directly in SO without any negative effects.

[shayrybak]

updated.`
@zroubalik this is what we've done temporarily to work around this, but it seems like a lot of effort for such a small change. I understand the use case to have my own SO if I mix other scaler tiriggers, but for a simple use case it's nice to have this.

Like I said in the issue, the use case is starting up sandbox environments so it's nice to have them up before they automatically scale down based on usage.

[zroubalik]

Makes sense, no objections from my side.

[zero101010]

Should we really do this? We could easily end up in 1-1 relation with ScaledObject's field, I wonder whether we should users encourage to specify this on the SO directly 🤔

Yes. it's really useful. Yesterday I need to do a workaround to use this. I'm really excited to have this on keda.

[zroubalik]

Yesterday I need to do a workaround to use this

Just out of curiosity, what workaround that was?

[zero101010]

Yesterday I need to do a workaround to use this

Just out of curiosity, what workaround that was?

I created the httpScaleObject and patch the scaleObject to add initalCooldownPeriod and then apply the other resources. I'm really happy that this feature it's added