Skip to content

Commit

Permalink
Update deprecated annotations in example demo (#979)
Browse files Browse the repository at this point in the history
* Update deprecated annotations ingress.yaml

The annotation one is being deprecated 

Signed-off-by: Joey Chen <[email protected]>

* Update CHANGELOG.md

Signed-off-by: Joey Chen <[email protected]>

* Update CHANGELOG.md

Fix order to pass the Static Checks. 

Signed-off-by: Joey Chen <[email protected]>

---------

Signed-off-by: Joey Chen <[email protected]>
  • Loading branch information
JoeyC-Dev authored Apr 21, 2024
1 parent f7bb9f5 commit 473c42c
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ You can find all deprecations in [this overview](https://github.com/kedacore/htt

### Other

- **General**: Align with the new format of Ingress in the example demo ([#979](https://github.com/kedacore/http-add-on/pull/979))
- **General**: Unify loggers ([#958](https://github.com/kedacore/http-add-on/issues/958))

## v0.7.0
Expand Down
2 changes: 1 addition & 1 deletion examples/xkcd/templates/ingress.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@ metadata:
name: {{ include "xkcd.fullname" . }}
annotations:
nginx.ingress.kubernetes.io/rewrite-target: /
kubernetes.io/ingress.class: nginx
spec:
ingressClassName: nginx
rules:
{{- range .Values.hosts }}
- host: {{ . | toString }}
Expand Down

0 comments on commit 473c42c

Please sign in to comment.