Skip to content

Commit

Permalink
btrfs-progs: build: drop kernel-lib from -I and update paths
Browse files Browse the repository at this point in the history
Include the files by full path to avoid any confusion in case of
potentially duplicate names.

Signed-off-by: David Sterba <[email protected]>
  • Loading branch information
kdave committed Jul 3, 2019
1 parent c07960c commit 94fced6
Show file tree
Hide file tree
Showing 54 changed files with 72 additions and 74 deletions.
1 change: 0 additions & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,6 @@ CFLAGS = $(SUBST_CFLAGS) \
-fno-strict-aliasing \
-fPIC \
-I$(TOPDIR) \
-I$(TOPDIR)/kernel-lib \
-I$(TOPDIR)/libbtrfsutil \
$(DISABLE_WARNING_FLAGS) \
$(EXTRAWARN_CFLAGS) \
Expand Down
2 changes: 1 addition & 1 deletion btrfs-corrupt-block.c
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
#include "disk-io.h"
#include "print-tree.h"
#include "transaction.h"
#include "list.h"
#include "kernel-lib/list.h"
#include "common/utils.h"
#include "common/help.h"

Expand Down
2 changes: 1 addition & 1 deletion btrfs-crc.c
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
#include <stdio.h>
#include <stdlib.h>
#include <unistd.h>
#include "crc32c.h"
#include "kernel-lib/crc32c.h"
#include "common/utils.h"

void print_usage(int status)
Expand Down
4 changes: 2 additions & 2 deletions btrfs-find-root.c
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,10 @@
#include "disk-io.h"
#include "print-tree.h"
#include "transaction.h"
#include "list.h"
#include "kernel-lib/list.h"
#include "volumes.h"
#include "common/utils.h"
#include "crc32c.h"
#include "kernel-lib/crc32c.h"
#include "extent-cache.h"
#include "find-root.h"
#include "common/help.h"
Expand Down
2 changes: 1 addition & 1 deletion btrfs-list.h
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@

#if BTRFS_FLAT_INCLUDES
#include "kerncompat.h"
#include "rbtree.h"
#include "kernel-lib/rbtree.h"
#include "ioctl.h"
#else
#include <btrfs/kerncompat.h>
Expand Down
2 changes: 1 addition & 1 deletion btrfs-map-logical.c
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
#include "disk-io.h"
#include "print-tree.h"
#include "transaction.h"
#include "list.h"
#include "kernel-lib/list.h"
#include "common/utils.h"
#include "common/help.h"

Expand Down
2 changes: 1 addition & 1 deletion btrfs-sb-mod.c
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
#include <string.h>
#include <limits.h>
#include <byteswap.h>
#include <kernel-lib/crc32c.h>
#include "kernel-lib/crc32c.h"
#include "disk-io.h"

#define BLOCKSIZE (4096)
Expand Down
2 changes: 1 addition & 1 deletion btrfs-select-super.c
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
#include "disk-io.h"
#include "print-tree.h"
#include "transaction.h"
#include "list.h"
#include "kernel-lib/list.h"
#include "common/utils.h"
#include "common/help.h"

Expand Down
2 changes: 1 addition & 1 deletion btrfs.c
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
#include <getopt.h>

#include "volumes.h"
#include "crc32c.h"
#include "kernel-lib/crc32c.h"
#include "cmds/commands.h"
#include "common/utils.h"
#include "common/help.h"
Expand Down
2 changes: 1 addition & 1 deletion btrfsck.h
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
#include "kerncompat.h"
#include "ctree.h"
#include "extent-cache.h"
#include "list.h"
#include "kernel-lib/list.h"
#else
#include <btrfs/kerncompat.h>
#include <btrfs/ctree.h>
Expand Down
4 changes: 2 additions & 2 deletions cmds/filesystem-du.c
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,9 @@
#include "common/utils.h"
#include "cmds/commands.h"
#include "kerncompat.h"
#include "rbtree.h"
#include "kernel-lib/rbtree.h"

#include "interval_tree_generic.h"
#include "kernel-lib/interval_tree_generic.h"
#include "common/help.h"
#include "common/fsfeatures.h"

Expand Down
2 changes: 1 addition & 1 deletion cmds/filesystem.c
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
#include "volumes.h"
#include "cmds/commands.h"
#include "cmds/filesystem-usage.h"
#include "list_sort.h"
#include "kernel-lib/list_sort.h"
#include "disk-io.h"
#include "common/help.h"
#include "common/fsfeatures.h"
Expand Down
4 changes: 2 additions & 2 deletions cmds/inspect-dump-super.c
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,10 @@
#include "disk-io.h"
#include "print-tree.h"
#include "transaction.h"
#include "list.h"
#include "kernel-lib/list.h"
#include "common/utils.h"
#include "cmds/commands.h"
#include "crc32c.h"
#include "kernel-lib/crc32c.h"
#include "common/help.h"

static int check_csum_sblock(void *sb, int csum_size)
Expand Down
2 changes: 1 addition & 1 deletion cmds/inspect-dump-tree.c
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
#include <getopt.h>

#include "kerncompat.h"
#include "radix-tree.h"
#include "kernel-lib/radix-tree.h"
#include "ctree.h"
#include "disk-io.h"
#include "print-tree.h"
Expand Down
2 changes: 1 addition & 1 deletion cmds/inspect-tree-stats.c
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
#include "disk-io.h"
#include "print-tree.h"
#include "transaction.h"
#include "list.h"
#include "kernel-lib/list.h"
#include "volumes.h"
#include "common/utils.h"
#include "cmds/commands.h"
Expand Down
2 changes: 1 addition & 1 deletion cmds/receive.c
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
#include "ioctl.h"
#include "cmds/commands.h"
#include "common/utils.h"
#include "list.h"
#include "kernel-lib/list.h"
#include "btrfs-list.h"

#include "send.h"
Expand Down
6 changes: 3 additions & 3 deletions cmds/rescue-chunk-recover.c
Original file line number Diff line number Diff line change
Expand Up @@ -29,14 +29,14 @@
#include <uuid/uuid.h>
#include <pthread.h>

#include "list.h"
#include "radix-tree.h"
#include "kernel-lib/list.h"
#include "kernel-lib/radix-tree.h"
#include "ctree.h"
#include "extent-cache.h"
#include "disk-io.h"
#include "volumes.h"
#include "transaction.h"
#include "crc32c.h"
#include "kernel-lib/crc32c.h"
#include "common/utils.h"
#include "btrfsck.h"
#include "cmds/commands.h"
Expand Down
4 changes: 2 additions & 2 deletions cmds/rescue-super-recover.c
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,9 @@
#include "kerncompat.h"
#include "ctree.h"
#include "disk-io.h"
#include "list.h"
#include "kernel-lib/list.h"
#include "common/utils.h"
#include "crc32c.h"
#include "kernel-lib/crc32c.h"
#include "volumes.h"
#include "cmds/commands.h"
#include "cmds/rescue.h"
Expand Down
2 changes: 1 addition & 1 deletion cmds/restore.c
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
#include "disk-io.h"
#include "print-tree.h"
#include "transaction.h"
#include "list.h"
#include "kernel-lib/list.h"
#include "volumes.h"
#include "common/utils.h"
#include "cmds/commands.h"
Expand Down
2 changes: 1 addition & 1 deletion cmds/send.c
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
#include "ctree.h"
#include "ioctl.h"
#include "cmds/commands.h"
#include "list.h"
#include "kernel-lib/list.h"
#include "common/utils.h"

#include "send.h"
Expand Down
4 changes: 2 additions & 2 deletions common/utils.c
Original file line number Diff line number Diff line change
Expand Up @@ -43,11 +43,11 @@
#include <btrfsutil.h>

#include "kerncompat.h"
#include "radix-tree.h"
#include "kernel-lib/radix-tree.h"
#include "ctree.h"
#include "disk-io.h"
#include "transaction.h"
#include "crc32c.h"
#include "kernel-lib/crc32c.h"
#include "common/utils.h"
#include "volumes.h"
#include "ioctl.h"
Expand Down
2 changes: 1 addition & 1 deletion common/utils.h
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
#include "common-defs.h"
#include "common/internal.h"
#include "btrfs-list.h"
#include "sizes.h"
#include "kernel-lib/sizes.h"
#include "common/messages.h"
#include "ioctl.h"
#include "common/fsfeatures.h"
Expand Down
2 changes: 1 addition & 1 deletion convert/source-reiserfs.c
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
#include "disk-io.h"
#include "transaction.h"
#include "common/utils.h"
#include "bitops.h"
#include "kernel-lib/bitops.h"
#include "convert/common.h"
#include "convert/source-reiserfs.h"

Expand Down
2 changes: 1 addition & 1 deletion ctree.c
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
#include "print-tree.h"
#include "repair.h"
#include "common/internal.h"
#include "sizes.h"
#include "kernel-lib/sizes.h"
#include "common/messages.h"
#include "volumes.h"

Expand Down
6 changes: 3 additions & 3 deletions ctree.h
Original file line number Diff line number Diff line change
Expand Up @@ -22,13 +22,13 @@
#include <stdbool.h>

#if BTRFS_FLAT_INCLUDES
#include "list.h"
#include "kernel-lib/list.h"
#include "kerncompat.h"
#include "radix-tree.h"
#include "kernel-lib/radix-tree.h"
#include "extent-cache.h"
#include "extent_io.h"
#include "ioctl.h"
#include "sizes.h"
#include "kernel-lib/sizes.h"
#else
#include <btrfs/list.h>
#include <btrfs/kerncompat.h>
Expand Down
4 changes: 2 additions & 2 deletions disk-io.c
Original file line number Diff line number Diff line change
Expand Up @@ -24,12 +24,12 @@
#include <unistd.h>
#include <uuid/uuid.h>
#include "kerncompat.h"
#include "radix-tree.h"
#include "kernel-lib/radix-tree.h"
#include "ctree.h"
#include "disk-io.h"
#include "volumes.h"
#include "transaction.h"
#include "crc32c.h"
#include "kernel-lib/crc32c.h"
#include "common/utils.h"
#include "print-tree.h"
#include "rbtree-utils.h"
Expand Down
2 changes: 1 addition & 1 deletion disk-io.h
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@

#include "kerncompat.h"
#include "ctree.h"
#include "sizes.h"
#include "kernel-lib/sizes.h"

#define BTRFS_SUPER_INFO_OFFSET SZ_64K
#define BTRFS_SUPER_INFO_SIZE 4096
Expand Down
2 changes: 1 addition & 1 deletion extent-cache.h
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@

#if BTRFS_FLAT_INCLUDES
#include "kerncompat.h"
#include "rbtree.h"
#include "kernel-lib/rbtree.h"
#else
#include <btrfs/kerncompat.h>
#include <btrfs/rbtree.h>
Expand Down
4 changes: 2 additions & 2 deletions extent-tree.c
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,12 @@
#include <stdint.h>
#include <math.h>
#include "kerncompat.h"
#include "radix-tree.h"
#include "kernel-lib/radix-tree.h"
#include "ctree.h"
#include "disk-io.h"
#include "print-tree.h"
#include "transaction.h"
#include "crc32c.h"
#include "kernel-lib/crc32c.h"
#include "volumes.h"
#include "free-space-cache.h"
#include "free-space-tree.h"
Expand Down
2 changes: 1 addition & 1 deletion extent_io.c
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
#include <stdbool.h>
#include "kerncompat.h"
#include "extent_io.h"
#include "list.h"
#include "kernel-lib/list.h"
#include "ctree.h"
#include "volumes.h"
#include "common/utils.h"
Expand Down
2 changes: 1 addition & 1 deletion extent_io.h
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
#if BTRFS_FLAT_INCLUDES
#include "kerncompat.h"
#include "extent-cache.h"
#include "list.h"
#include "kernel-lib/list.h"
#else
#include <btrfs/kerncompat.h>
#include <btrfs/extent-cache.h>
Expand Down
4 changes: 2 additions & 2 deletions file-item.c
Original file line number Diff line number Diff line change
Expand Up @@ -19,12 +19,12 @@
#include <stdio.h>
#include <stdlib.h>
#include "kerncompat.h"
#include "radix-tree.h"
#include "kernel-lib/radix-tree.h"
#include "ctree.h"
#include "disk-io.h"
#include "transaction.h"
#include "print-tree.h"
#include "crc32c.h"
#include "kernel-lib/crc32c.h"
#include "common/internal.h"

#define MAX_CSUM_ITEMS(r, size) ((((BTRFS_LEAF_DATA_SIZE(r->fs_info) - \
Expand Down
2 changes: 1 addition & 1 deletion find-root.h
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
#include "kerncompat.h"

#include "ctree.h"
#include "list.h"
#include "kernel-lib/list.h"
#include "extent-cache.h"

/*
Expand Down
4 changes: 2 additions & 2 deletions free-space-cache.c
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@
#include "transaction.h"
#include "disk-io.h"
#include "extent_io.h"
#include "crc32c.h"
#include "bitops.h"
#include "kernel-lib/crc32c.h"
#include "kernel-lib/bitops.h"
#include "common/internal.h"
#include "common/utils.h"

Expand Down
2 changes: 1 addition & 1 deletion free-space-cache.h
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@

#include "kerncompat.h"
#include "ctree.h"
#include "rbtree.h"
#include "kernel-lib/rbtree.h"

struct btrfs_free_space {
struct rb_node offset_index;
Expand Down
2 changes: 1 addition & 1 deletion free-space-tree.c
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
#include "free-space-tree.h"
#include "volumes.h"
#include "transaction.h"
#include "bitops.h"
#include "kernel-lib/bitops.h"
#include "common/internal.h"

static struct btrfs_free_space_info *
Expand Down
2 changes: 1 addition & 1 deletion hash.h
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
#ifndef __BTRFS_HASH_H__
#define __BTRFS_HASH_H__

#include "crc32c.h"
#include "kernel-lib/crc32c.h"

static inline u64 btrfs_name_hash(const char *name, int len)
{
Expand Down
2 changes: 1 addition & 1 deletion image/main.c
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
#include <getopt.h>

#include "kerncompat.h"
#include "crc32c.h"
#include "kernel-lib/crc32c.h"
#include "ctree.h"
#include "disk-io.h"
#include "transaction.h"
Expand Down
Loading

0 comments on commit 94fced6

Please sign in to comment.