Skip to content

Commit

Permalink
percpu: add a test case for the specific 64-bit value addition
Browse files Browse the repository at this point in the history
It might be a corner case when we add UINT_MAX as 64-bit unsigned value to
the percpu variable as it's not the same as -1 (ULONG_LONG_MAX).  Add a
test case for that.

Link: https://lkml.kernel.org/r/[email protected]
Signed-off-by: Andy Shevchenko <[email protected]>
Cc: Borislav Petkov (AMD) <[email protected]>
Cc: Christoph Lameter <[email protected]>
Cc: Dave Hansen <[email protected]>
Cc: Dennis Zhou <[email protected]>
Cc: "H. Peter Anvin" <[email protected]>
Cc: Ingo Molnar <[email protected]>
Cc: Ingo Molnar <[email protected]>
Cc: Tejun Heo <[email protected]>
Cc: Thomas Gleixner <[email protected]>
Cc: Uros Bizjak <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
  • Loading branch information
andy-shev authored and akpm00 committed Nov 7, 2024
1 parent 6c2625e commit 4a7bba1
Showing 1 changed file with 10 additions and 1 deletion.
11 changes: 10 additions & 1 deletion lib/percpu_test.c
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
// SPDX-License-Identifier: GPL-2.0-only
#include <linux/limits.h>
#include <linux/module.h>

/* validate @native and @pcp counter values match @expected */
Expand All @@ -24,8 +25,9 @@ static int __init percpu_test_init(void)
* +ul_one/-ul_one below would replace with inc/dec instructions.
*/
volatile unsigned int ui_one = 1;
long l = 0;
unsigned long long ull = 0;
unsigned long ul = 0;
long l = 0;

pr_info("percpu test start\n");

Expand Down Expand Up @@ -112,6 +114,13 @@ static int __init percpu_test_init(void)
CHECK(ul, ulong_counter, -1);
CHECK(ul, ulong_counter, ULONG_MAX);

ul = ull = 0;
__this_cpu_write(ulong_counter, 0);

ul = ull += UINT_MAX;
__this_cpu_add(ulong_counter, ull);
CHECK(ul, ulong_counter, UINT_MAX);

ul = 3;
__this_cpu_write(ulong_counter, 3);

Expand Down

0 comments on commit 4a7bba1

Please sign in to comment.