Skip to content

Add TWAP price-oracle and cross-function reentrancy check classes#62

Open
Pattermesh wants to merge 1 commit into
mainfrom
pattermesh/audit-checklist-oracle-reentrancy
Open

Add TWAP price-oracle and cross-function reentrancy check classes#62
Pattermesh wants to merge 1 commit into
mainfrom
pattermesh/audit-checklist-oracle-reentrancy

Add TWAP price-oracle and cross-function reentrancy check classes

afddea1
Select commit
Loading
Failed to load commit list.
GitHub Advanced Security / Slither failed Jun 29, 2026 in 7s

6 new alerts including 1 high severity security vulnerability

New alerts in code changed by this pull request

Security Alerts:

  • 1 high
  • 4 medium

Other Alerts:

  • 1 warning

See annotations below for details.

View all branch alerts.

Annotations

Check failure on line 68 in src/examples/CrossFunctionReentrancyExamples.sol

See this annotation in the file changed.

Check warning on line 128 in src/checks/CrossFunctionReentrancyCheck.sol

See this annotation in the file changed.

Code scanning / Slither

Contracts that lock Ether Medium

Contract locking ether found:
Contract CrossFunctionReentrantAttacker has payable functions:
- CrossFunctionReentrantAttacker.receive()
But does not have a function to withdraw the ether

Check warning on line 103 in src/checks/CrossFunctionReentrancyCheck.sol

See this annotation in the file changed.

Code scanning / Slither

State variables that could be declared immutable Warning

CrossFunctionReentrantAttacker.target should be immutable

Check warning on line 69 in src/examples/CrossFunctionReentrancyExamples.sol

See this annotation in the file changed.

Code scanning / Slither

Incorrect erc20 interface Medium

VulnerableCrossFunctionVault has incorrect ERC20 function interface:VulnerableCrossFunctionVault.transfer(address,uint256)

Check warning on line 98 in src/examples/CrossFunctionReentrancyExamples.sol

See this annotation in the file changed.

Code scanning / Slither

Incorrect erc20 interface Medium

SafeCrossFunctionVault has incorrect ERC20 function interface:SafeCrossFunctionVault.transfer(address,uint256)

Check warning on line 56 in src/examples/TWAPOracleExamples.sol

See this annotation in the file changed.

Code scanning / Slither

Divide before multiply Medium

MockTWAPPair._accumulate() performs a multiplication on the result of a division:
- price0 = (uint256(reserve1) * 1e18) / uint256(reserve0)
- price0CumulativeLast += price0 * timeElapsed